Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSK-259] Create a List UI component ( similar to Notion) that wraps around AG Grid #8

Merged
merged 16 commits into from
Aug 11, 2024
Merged

[TSK-259] Create a List UI component ( similar to Notion) that wraps around AG Grid #8

merged 16 commits into from
Aug 11, 2024

Commits on Aug 3, 2024

  1. CreateConversationDialog: adapted from CreateResearchContextDialog 

    - Added also stories and tests
    @carlapbg @alebg
    carlapbg authored and alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    31455a0 View commit details
    Browse the repository at this point in the history

  2. fix: linting

    @carlapbg @alebg
    carlapbg authored and alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    d055c58 View commit details
    Browse the repository at this point in the history

  3. review with broken stuff to fix

    @maany @alebg
    maany authored and alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    c0f4276 View commit details
    Browse the repository at this point in the history

  4. CreateResearchContextDialog: updated code following latest review 

    - Improved tailwind theme
    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    ceb1c7c View commit details
    Browse the repository at this point in the history

  5. fix: linting

    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    2c2b52b View commit details
    Browse the repository at this point in the history

  6. Adapt ConversationDialog and LoginCard following latest review 

    - Create test for LoginCard
- Adapt test for ConversationDialog
    @carlapbg @alebg
    carlapbg authored and alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    b1c91e2 View commit details
    Browse the repository at this point in the history

  7. SourceDataTable: basic one with the option to add sortable columns; w… 

    …ith pagination and controls

- Todo: styling, filtering
    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    7762d5f View commit details
    Browse the repository at this point in the history

  8. SourceDataTable: added select checkbox, and global filter input bar

    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    5038ebd View commit details
    Browse the repository at this point in the history

  9. SourceDataTable: Fixed linting, added selection option 

    - todo: test how selected items are handled
  + E.g., one page will need batch download; another one will need the selection to create a conversation
- todo: improve actions
  + Download
  + Copy relative path
  + Copy name
- Todo: code, apart from this, a simple upload button that will be combined with the table for one of the pages
    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    6503942 View commit details
    Browse the repository at this point in the history

  10. feat: working examples of AG Grid base and source data tables 

    - todo: theming; selection actions
    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    72be8bf View commit details
    Browse the repository at this point in the history

  11. fix: standardized grid API calls in BaseAGGrid, following the officia… 

    …l docs for React
    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    7470f93 View commit details
    Browse the repository at this point in the history

  12. fix: linting

    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    032e5c1 View commit details
    Browse the repository at this point in the history

  13. feat: BaseAGGrid can now be passed a function + label as props, and c… 

    …reates a button that executes the function on a list of selected rows

- Also, reorganized Story paths
    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    370c1f8 View commit details
    Browse the repository at this point in the history

  14. feat: BaseAGGrid tables now accept an arbitrary number of components … 

    …+ callBack functions as inputs, and renders them in the top div

- Improved style and allowed for dark mode of top div
- TODO: AGGrid theming
    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    1b48173 View commit details
    Browse the repository at this point in the history

  15. fix: line that got lost during rebasing

    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    6bc32ee View commit details
    Browse the repository at this point in the history

  16. feat: improved style of AGGrid components 

    - Theming had to be hardcoded in the AG Grid way (with a css file, generated by their official theme builder), couldn't make it work with tailwind. NOTE: it's always in dark mode
- Similarly, height and width of the AG Grid are not straightforwardly manipulated, so they have to be more or less hardcoded in the AG Grid variants (Source Data and Conversations) depending on the amount of columns
    @alebg
    alebg committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    00124ce View commit details
    Browse the repository at this point in the history