[TSK-259] Create a List UI component ( similar to Notion) that wraps around AG Grid #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added also stories and tests
- Improved tailwind theme
- Create test for LoginCard - Adapt test for ConversationDialog
…ith pagination and controls - Todo: styling, filtering
- todo: test how selected items are handled + E.g., one page will need batch download; another one will need the selection to create a conversation - todo: improve actions + Download + Copy relative path + Copy name - Todo: code, apart from this, a simple upload button that will be combined with the table for one of the pages
- todo: theming; selection actions
…reates a button that executes the function on a list of selected rows - Also, reorganized Story paths
…+ callBack functions as inputs, and renders them in the top div - Improved style and allowed for dark mode of top div - TODO: AGGrid theming
- Theming had to be hardcoded in the AG Grid way (with a css file, generated by their official theme builder), couldn't make it work with tailwind. NOTE: it's always in dark mode - Similarly, height and width of the AG Grid are not straightforwardly manipulated, so they have to be more or less hardcoded in the AG Grid variants (Source Data and Conversations) depending on the amount of columns
Coverage Report
File CoverageNo changed files found. |
|
@manny, could you review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.