-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to lld and compiler-rt #31
base: master
Are you sure you want to change the base?
Conversation
Either the __builtin_constant_p or the less than operator is returning the wrong result causing the wrong leg of the conditional to be taken.
@@ -170,10 +170,17 @@ | |||
asm volatile ("csrr %0, " #reg : "=r"(__tmp)); \ | |||
__tmp; }) | |||
|
|||
/* TODO: */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be resolved before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove the TODO and the commented code. Jesse's fix should be OK. It matches the macro definitions in recent versions of encoding.h
in riscv-opcodes
.
{ | ||
. = ALIGN(4); | ||
PROVIDE( _data_lma = . ); | ||
} >flash AT>flash :flash | ||
|
||
.dalign : | ||
.dalign ALIGN(4): | ||
{ | ||
. = ALIGN(4); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't some of these already aligned? (Like this one.)
No description provided.