Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] playground tests - show live output from the tests #6564

Merged
merged 3 commits into from
Oct 31, 2024
+10 −1
Merged

[ci] playground tests - show live output from the tests #6564

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e1a712
[ci] playground tests - show live output from the tests
radical Oct 30, 2024
62d949c
Address review feedback from @ damianedwards
radical Oct 30, 2024
9455f5d
address review feedbacvk from @ bradwilson
radical Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/helix/send-to-helix-buildonhelixtests.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
<_TestBlameArguments Include="--blame-crash-dump-type full" />

<!-- Using `dotnet test` for the project directly here -->
<_TestRunCommandArguments Include="dotnet test -s .runsettings --results-directory $(_HelixLogsPath)" />
<_TestRunCommandArguments Include="dotnet test -s .runsettings --results-directory $(_HelixLogsPath) -v:n" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this when the .runsettings also has:

      <Logger friendlyName="console">
        <Configuration>
          <Verbosity>normal</Verbosity>
        </Configuration>
      </Logger>

?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing -v:n to dotnet test changes the verbosity of the MSBuild operations that dotnet test does, which is different than the verbosity of the console logger.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need -v:n so the msbuild logger shows the live output.

<_TestRunCommandArguments Include="@(_TestBlameArguments, ' ')" />
</ItemGroup>

Expand Down
Loading