-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] playground tests - show live output from the tests #6564
Conversation
@radical should we update the xunit runner settings to enable live output too? |
Is this sufficient to show the output in VS? If so, this sounds like a great idea. |
Add `ShowLiveOutput=true` for playground, endtoend, and workload tests.
Unfortunately I don't think it works in VS @bradwilson |
It does work. The output goes to the Tests tab of the Output window. live.output.mp4 |
Also, if you want to see live output with live.output.dotnet.mp4 |
@@ -35,7 +35,7 @@ | |||
<_TestBlameArguments Include="--blame-crash-dump-type full" /> | |||
|
|||
<!-- Using `dotnet test` for the project directly here --> | |||
<_TestRunCommandArguments Include="dotnet test -s .runsettings --results-directory $(_HelixLogsPath)" /> | |||
<_TestRunCommandArguments Include="dotnet test -s .runsettings --results-directory $(_HelixLogsPath) -v:n" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this when the .runsettings also has:
<Logger friendlyName="console">
<Configuration>
<Verbosity>normal</Verbosity>
</Configuration>
</Logger>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing -v:n
to dotnet test
changes the verbosity of the MSBuild operations that dotnet test
does, which is different than the verbosity of the console logger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need -v:n
so the msbuild logger shows the live output.
@@ -1,5 +1,8 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<RunSettings> | |||
<xunit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually working for you? My understanding was that these are case sensitive (because thanks XML), and these should be xUnit
(with the capital U). https://xunit.net/docs/runsettings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thank you. I will fix that.
Microsoft Reviewers: Open in CodeFlow