Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MX blocklist checking #202

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Remove MX blocklist checking #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cb5bdd
Remove blocklist checking for MX records
MattIPv4 Jan 3, 2024
03393ee
Fix missing space before learn more link
MattIPv4 Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 0 additions & 70 deletions src/dns-lookup/blocklists.ts
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions src/dns-lookup/data/blocklists.ts
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions src/dns-lookup/i18n/en/templates/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import app from "./app"
import dodns from "./dodns"
import mxBlocklist from "./mx_blocklist"
import records from "./records"
import truncatedRecord from "./truncated_record"
import whois from "./whois"
Expand All @@ -11,7 +10,7 @@ import clipboardModal from "./clipboard_modal"
import dmarcExplainer from "./dmarc_explainer"

export default {
app, dodns, mxBlocklist, records, truncatedRecord,
app, dodns, records, truncatedRecord,
whois, propagationModal, recordSelectionModal,
dnsDiff, clipboardModal, dmarcExplainer,
} as {[key: string]: {[key: string]: any}}
6 changes: 0 additions & 6 deletions src/dns-lookup/i18n/en/templates/mx_blocklist.ts
View file
Open in desktop

This file was deleted.

91 changes: 0 additions & 91 deletions src/dns-lookup/templates/mx_blocklist.vue
View file
Open in desktop

This file was deleted.

10 changes: 3 additions & 7 deletions src/dns-lookup/templates/record.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!--
Copyright 2022 DigitalOcean
Copyright 2024 DigitalOcean

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand All @@ -25,6 +25,7 @@ limitations under the License.
</h3>
<p>
<span v-html="recordDescription"></span>
{{ " " }}
<ExternalLink :link="recordUrl" :text="i18n.templates.records.learnMore" />
</p>
<div v-if="recordKeys.length === 0">
Expand Down Expand Up @@ -62,12 +63,9 @@ limitations under the License.
</div>
<div v-else>
{{ value.result }}
<div v-if="value.hostname">
<div v-if="value.ip">
<hr />
<WHOIS :ip="value.ip"></WHOIS>
<div v-if="recordType === 'MX'">
<MXBlocklist :ip="value.ip" :hostname="value.hostname ? value.hostname : ''"></MXBlocklist>
</div>
</div>
</div>
</div>
Expand Down Expand Up @@ -127,7 +125,6 @@ limitations under the License.
import registrarRegexp from "../data/registrar_regexp"
import nsRegexp from "../data/ns_regexp"
import RecordTutorials from "../data/record_tutorials"
import MXBlocklist from "./mx_blocklist"
import RecordSkeleton from "./skeletons/record"
import i18n from "../i18n"
import DNSDiff from "./dns_diff"
Expand Down Expand Up @@ -160,7 +157,6 @@ limitations under the License.
components: {
TruncatedRecord,
WHOIS,
MXBlocklist,
RecordSkeleton,
DNSDiff,
ExternalLink,
Expand Down