Remove MX blocklist checking #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
force-pushed
the
MattIPv4/fix-blocklist-checks
branch
from
55b8845
to
03393ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
What issue does this relate to?
Closes #2
What should this PR do?
Removes the MX blocklist checking, as SpamHaus (the main provider we were using) no longer support being queried from public resolvers, such as Cloudflare's DoH API. Additionally, this feature was generally confusing/misleading to users as we were checking the IP/domain for their MX records, which are used for receiving email, not sending email.
What are the acceptance criteria?
MX blocklist checking removed. Tool otherwise continues to function as expected.