Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci fixes: Update python version coverage and flake8 dependencies. #247

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ci fixes: Update python version coverage and flake8 dependencies. #247

wants to merge 4 commits into from

Conversation

nuclearsandwich
Copy link
Contributor

This sequence of PRs gets the GitHub Actions CI running again.

The following changes are included:

  • Update the python versions covered to 3.6 - 3.10 on the latest Ubuntu, 3.10 on macOS, and 3.8, 3.10 on Windows (3.8 is still used by ROS 2), python versions are also string quoted so yaml does not interpret 3.10 as 3.1.
  • Move test dependencies to extras_require.test following the conventions adopted for ROS infrastructure packages.
  • Add a requirement for flake8 < 5 due to breaking changes. The ROS infra team will be looking further at flake8 5 compatibility in the coming weeks and I hope to apply whatever we do there to vcstool as well. This gets CI operational in the meantime.

@nuclearsandwich
Update python versions tested in CI.
e53a9a5
@nuclearsandwich
Quote all python versions in yaml.
70f520c 
Python 3.1 != Python 3.10
@nuclearsandwich
Add extras_require.test and pin flake8 < 5.
533e4a0 
flake8 5 removes the API being used for configuration.
It's unclear to me as of yet whether it is possible to make this setup
work for both Flake8 <5 and Flake8 5. The ROS infra team has not tackled
this yet.

In the meantime, let's try to get the workflow going again using flake8
4.

Also removes the variable indirection for installs_require since it
isn't used to do anything at the moment.
@nuclearsandwich
Use extras_require.test to install test dependencies.
3b0f0d1 
Following the convention established by ROS infrastructure packages I've
left coverage out of the required test dependencies so it is still
installed explicitly for the GitHub action.
@nuclearsandwich nuclearsandwich mentioned this pull request Sep 6, 2022
Open
@christophebedard christophebedard mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nuclearsandwich