Use chardet by default to find the encoding #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check if sources: 69shu.com works with the code. |
|
When I remove the custom get_soup It works with 69shu.com with no issue |
|
Chardet seems to make a lot of mistake in finding the encoding, I'm not sure if it should get merged. For example it messed up the encoding here : |
|
I merged this to enable passing custom encoding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2022 for context
I tried a few different sources, and it did not seem to cause any issues.
I still added it as an argument to be able to overwrite it if chardet can't determine encoding.