Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please please add password input for this source! :D #2064

Closed
norabelle101 opened this issue Aug 26, 2023 · 8 comments
Closed

Please please add password input for this source! :D #2064

norabelle101 opened this issue Aug 26, 2023 · 8 comments

Comments

@norabelle101
Copy link

Hello! I'm a new user of your brilliant program!! If it's permissible, I would like to request that a password input be integrated into the parser for the source: https://chrysanthemumgarden.com/

If it's possible, when the parser is scanning the novel page for the chapters, could it also detect whether some chapters within the Table of Contents are password-locked and will then prompt the user to input the password in order to proceed further? If the user chooses not to input the password, then Lightnovel Crawler will not result in any error, but it will just output only the accessible unlocked chapters? So this also means that if the entire novel has no password-locked chapters, the program will simply skip over this input and give no prompt about the password.

I saw that Webtoepub has integrated a password input specifically for this source (because it hosts lots of novels) which was able to successfully bypass it. But I like the format for your program and it's crawling ability (in not grabbing too many html elements) so I was wondering if maybe it'd be possible for Lightnovel Crawler to also implement this function? And your program was already able to completely fix the gibberish text which was a separate issue, so I was really amazed by that!

image

Hoping this is possible!! Thank you very much!!! :D

P.S. But I sincerely apologise if someone else has already made this request and it wasn't permitted. Thank you regardless.

@jere344
Copy link
Contributor

jere344 commented Aug 26, 2023

I think it already work similarly. When downloading from here it will ask you to login. If you do you can put anything in the username field (it's useless) and the password field is the password of the week. It will then download locked or unlocked chapters without issues.
If you don't it will download unlocked chapter, and just get failed to download chapter body for locked ones.

Edit : it was merged yesterday #2042 so it's only available in the dev branch for now. It will probably be merged to master in ~a week

@norabelle101
Copy link
Author

@jere344

AH okay!! I see, thank you very much! I shall wait for the new update. But I apologise for another question, I only just started using Lightnovel Crawler a couple days ago and I was wondering how to update the file? Does my existing downloaded .exe file automatically update when new commits are merged into the master branch? Or do I need to download the new .exe file that releases each time?

Apologies for the inconvenience and thank you very much for your speedy response!

@zGadli
Copy link
Contributor

zGadli commented Aug 27, 2023

@vanessabluellie You could fork the dev branch from this repo and follow the steps in Readme.md to run the latest version. Or you could check your lightnovel-crawler version if it is below 3.2.10 then install the it again.

@norabelle101
Copy link
Author

@zGadli

Oh okay!! I umm actually just tried generating a novel from ChrysanthemumGarden with the new commit but umm the source is completely broken now...

Regardless of whether I choose "Yes" or "No" for login option, nothing will generate into the epub at all. Every chapter will only contain the text "Failed to download chapter body".

I used the password for "Yes" and nothing generated (not even the unlocked chapters that don't require a password). But then I switched and selected "No" for login and still the same result? No chapter text at all, only the headings and error message.

This was the error:

image

It appears for every single selected chapter when it attempted to grab the chapters and generate the epub :'(

I apologise again for the inconvenience!

@jere344
Copy link
Contributor

jere344 commented Aug 27, 2023

@vanessabluellie
You need to update the app to the dev branch too, not only the source because it needs #2040 to work.
There was also another issue fixed here #2066 not yet merged

You can wait until it get fully updated or if you want to use the source right now you can go to sources\en\c\chrysanthemumgarden.py and edit it :
remove encoding="utf8", line 82
remove multipart=True, line 75
remove , encoding="utf8" line 70

@norabelle101
Copy link
Author

norabelle101 commented Aug 28, 2023

@jere344

OH okay!! Thank you!! I shall wait for the update! :D

@zGadli
Copy link
Contributor

zGadli commented Sep 6, 2023

@vanessabluellie The app is updated. Try and check if the issue is fixed. If it is close the issue.

@norabelle101
Copy link
Author

@zGadli

AH yes, it works perfectly!!! :D Thank you for all your time and effort! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants