Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(frontend): put buttons at the extreme bottoms for smaller screens [GIX-3015] #2555

Merged
merged 4 commits into from
Sep 29, 2024
Merged

style(frontend): put buttons at the extreme bottoms for smaller screens [GIX-3015] #2555

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7688e28
style(frontend): put buttons at the extreme bottoms for smaller screens
AntonioVentilii Sep 27, 2024
4fdb91b
refactor: use mixin media
AntonioVentilii Sep 27, 2024
bd1aae2
style: use flex 1
AntonioVentilii Sep 27, 2024
857ee68
Merge branch 'main' into style(frontend)/put-buttons-at-the-extreme-b…
AntonioVentilii-DFINITY Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/frontend/src/lib/styles/global/gix.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,12 @@ div.modal {
border-radius: 0;

div.content {
height: 100vh;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry did not noticed it before, that's correct?

  1. The inner content is not 100vh no?
  2. On desktop we don't want 100vh?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right: that was a poor solution. After a few iterations, I found that the best way is to set flex: 1 (see last commit.

For context, before this last solution, the ideal would have been 100%, but it was not working... The 100vh worked without going outside the parent... (see video below)

Screen.Recording.2024-09-27.at.13.22.57.mov

padding-inline: var(--padding-2_5x);

@include media.min-width(medium) {
height: auto;
}
}
}
}
Expand Down