style(frontend): put buttons at the extreme bottoms for smaller screens [GIX-3015] #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii-DFINITY
changed the title
| padding-inline: var(--padding-2_5x); | ||
|
|
||
| @media (min-width: 768px) { |
There was a problem hiding this comment.
You can use @include media.min-width(medium) { from the mixin in gix cmp.
There was a problem hiding this comment.
thank you! done!
AntonioVentilii-DFINITY
requested review from
peterpeterparker and
DenysKarmazynDFINITY
| @@ -145,7 +145,12 @@ div.modal { | |||
| border-radius: 0; | |||
|
|
|||
| div.content { | |||
| height: 100vh; | |||
There was a problem hiding this comment.
Sorry did not noticed it before, that's correct?
- The inner content is not 100vh no?
- On desktop we don't want 100vh?
There was a problem hiding this comment.
You are right: that was a poor solution. After a few iterations, I found that the best way is to set flex: 1 (see last commit.
For context, before this last solution, the ideal would have been 100%, but it was not working... The 100vh worked without going outside the parent... (see video below)
Screen.Recording.2024-09-27.at.13.22.57.mov
…ottoms-for-smaller-screens
AntonioVentilii-DFINITY
deleted the
style(frontend)/put-buttons-at-the-extreme-bottoms-for-smaller-screens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It was noticed that the buttons in modals for smaller screens are not at the extreme bottom, if the phone is longer.
Before
After