Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unknown lookup status of a path in certificate yields AgentError #453

Merged
merged 8 commits into from
Sep 11, 2023
Merged

feat: Unknown lookup status of a path in certificate yields AgentError #453

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d3a9d4c
Unknown lookup status of a path in certificate yields AgentError
mraszyk Aug 3, 2023
a81feaf
fix build
mraszyk Aug 3, 2023
ac13cb6
Update CHANGELOG.md
mraszyk Aug 3, 2023
fead1b3
Merge branch 'main' into mraszyk/unknown-is-agent-error
mraszyk Aug 21, 2023
aa01228
Merge branch 'main' into mraszyk/unknown-is-agent-error
mraszyk Aug 22, 2023
6affa7f
Merge branch 'main' into mraszyk/unknown-is-agent-error
mraszyk Aug 23, 2023
3f507d9
Merge branch 'main' into mraszyk/unknown-is-agent-error
mraszyk Aug 30, 2023
0b9b3fd
Merge branch 'main' into mraszyk/unknown-is-agent-error
mraszyk Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased

* The `Unknown` lookup of a request_status path in a certificate results in an `AgentError` (the IC returns `Absent` for non-existing paths).

## [0.25.0] - 2023-07-05

* Breaking Change: builders are now owning-style rather than borrowing-style; with_arg takes an owned Vec rather than a borrowed Vec
Expand Down
2 changes: 1 addition & 1 deletion ic-agent/src/agent/response_authentication.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ pub(crate) fn lookup_request_status<Storage: AsRef<[u8]>>(
];
match certificate.tree.lookup_path(&path_status) {
LookupResult::Absent => Ok(RequestStatusResponse::Unknown),
LookupResult::Unknown => Ok(RequestStatusResponse::Unknown),
LookupResult::Unknown => Err(LookupPathUnknown(path_status.to_vec())),
mraszyk marked this conversation as resolved.
Show resolved Hide resolved
LookupResult::Found(status) => match from_utf8(status)? {
"done" => Ok(RequestStatusResponse::Done),
"processing" => Ok(RequestStatusResponse::Processing),
Expand Down
Loading