Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unknown lookup status of a path in certificate yields AgentError #453

Merged
merged 8 commits into from
Sep 11, 2023
Merged

feat: Unknown lookup status of a path in certificate yields AgentError #453

merged 8 commits into from
Sep 11, 2023

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Aug 3, 2023

Description

Absence proofs have been recently enabled on the IC (see MR) and thus the IC is going to produce certificate whose lookup returns Absent for paths whose values are missing in the state tree. This PR reflects this change in the agent.

@mraszyk mraszyk requested a review from a team as a code owner August 3, 2023 15:22
CHANGELOG.md Outdated Show resolved Hide resolved
ic-agent/src/agent/response_authentication.rs Show resolved Hide resolved
Co-authored-by: Eric Swanson <[email protected]>
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's hold off on merging this until the relevant replica update has been executed. Otherwise, we wouldn't be able to release agent-rs in the meantime with other changes.

@mraszyk
Copy link
Contributor Author

mraszyk commented Aug 21, 2023

The replica release containing absence proofs has been rolled out on all subnets. So we can proceed with this MR.

@ericswanson-dfinity ericswanson-dfinity merged commit f8ceed9 into dfinity:main Sep 11, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants