Raise error on empty paged responses #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarman
reviewed
Mar 4, 2020
lib/vbms/service/paged_documents.rb
Outdated
| @@ -11,6 +11,9 @@ def call(file_number:) | |||
| req = next_request(file_number, 0) | |||
| first_page = client.send_request(req) | |||
|
|
|||
| # interpret a first page with no sections (and no doc count) as equivalent to zero pages. | |||
| raise ClientError.new("No sections found in first page") if first_page.empty? | |||
There was a problem hiding this comment.
agreed with your thought: let's have a specific error subclass ZeroPagesError here so that callers can decide what to do.
|
Rebased. |
nanotone
force-pushed
the
nanotone/empty-page-exception
branch
from
cc7fbd7
to
95b90bd
Compare
va-bot
pushed a commit
to department-of-veterans-affairs/caseflow
that referenced
this pull request
Mar 6, 2020
### Description Upgrade to latest `connect_vbms` git hash to get these goodies: department-of-veterans-affairs/connect_vbms#250 - fix pagination bug when VBMS returns fewer documents than reported department-of-veterans-affairs/connect_vbms#252 - handle VBMS returning no pages at all department-of-veterans-affairs/connect_vbms#253 - fix small security warning in Rake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects #251
This appears to be the first instance of connect_vbms raising an error for a request/response that's valid at the HTTP and SOAP levels. I wasn't sure if it's better to just raise a
ClientError, or to raise an instance of a subclass (PagingError?)