Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade connect_vbms: pagination fixes, small security warning #13634

Merged
merged 2 commits into from
Mar 6, 2020

Conversation

nanotone
Copy link
Contributor

@nanotone nanotone commented Mar 6, 2020

Description

Upgrade to latest connect_vbms git hash to get these goodies:

department-of-veterans-affairs/connect_vbms#250 - fix pagination bug when VBMS returns fewer documents than reported

department-of-veterans-affairs/connect_vbms#252 - handle VBMS returning no pages at all

department-of-veterans-affairs/connect_vbms#253 - fix small security warning in Rake

@codeclimate
Copy link

codeclimate bot commented Mar 6, 2020

Code Climate has analyzed commit 7f8ddd1 and detected 0 issues on this pull request.

View more on Code Climate.

@nanotone nanotone force-pushed the nanotone/upgrade-connect-vbms branch from 2fbbc83 to b4f3083 Compare March 6, 2020 01:11
Copy link
Contributor

@pkarman pkarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed SHAs

@pkarman pkarman added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Mar 6, 2020
@va-bot va-bot merged commit ba2edbd into master Mar 6, 2020
@va-bot va-bot deleted the nanotone/upgrade-connect-vbms branch March 6, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants