Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gosec fixes #41

Merged
merged 1 commit into from
Jul 19, 2024
Merged

gosec fixes #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions gonvme_tcp_fc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,16 @@ func (nvme *NVMe) getFCHostInfo() ([]FCHBAInfo, error) {
for _, m := range match {

var FCHostInfo FCHBAInfo
data, err := os.ReadFile(path.Join(m, "port_name"))
portNamePath := path.Join(m, "port_name")
data, err := os.ReadFile(filepath.Clean(portNamePath))
if err != nil {
log.Errorf("match: %s failed to read port_name file: %s", match, err.Error())
continue
}
FCHostInfo.PortName = strings.TrimSpace(string(data))

data, err = os.ReadFile(path.Join(m, "node_name"))
nodeNamePath := path.Join(m, "node_name")
data, err = os.ReadFile(filepath.Clean(nodeNamePath))
if err != nil {
log.Errorf("match: %s failed to read node_name file: %s", match, err.Error())
continue
Expand Down Expand Up @@ -426,7 +428,7 @@ func (nvme *NVMe) getInitiators(filename string) ([]string, error) {
}

// get the contents of the initiator config file
out, err := os.ReadFile(init)
out, err := os.ReadFile(filepath.Clean(init))
if err != nil {
log.Errorf("Error gathering initiator names: %v", err)
}
Expand Down