Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: benchmark using codspeed #2218

Merged
merged 6 commits into from
May 7, 2024
Merged

ci: benchmark using codspeed #2218

merged 6 commits into from
May 7, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 6, 2024

Summary by CodeRabbit

  • New Features

    • Integrated a new custom action to enhance the automation process in workflows.
    • Introduced a special pytest command for advanced testing capabilities.
  • Refactor

    • Enhanced benchmarking functions in testing for improved performance analysis.
  • Chores

    • Updated workflow configurations to utilize secure tokens for operations.

Copy link
Contributor

coderabbitai bot commented May 6, 2024

Walkthrough

Walkthrough

The recent updates enhance testing processes by leveraging a new action CodSpeedHQ/action to execute tox with tailored configurations and a security token. Benchmarking capabilities are improved through the addition of a @benchmark decorator in test scripts. The tox.ini file now incorporates a pytest --codspeed command for optimized testing efficiency.

Changes

Files Change Summary
.github/workflows/push.yml Replaced tox command with CodSpeedHQ/action for running tox with a token.
tox.ini Added pytest --codspeed command.
tests/test_reacnetgen.py Refactored benchmarking functions with a new @benchmark decorator.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 55691f5 and a31ae92.
Files selected for processing (1)
  • .github/workflows/benchmark.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/benchmark.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (101610b) to head (a31ae92).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2218   +/-   ##
=======================================
  Coverage   95.51%   95.51%           
=======================================
  Files          19       19           
  Lines        1471     1471           
=======================================
  Hits         1405     1405           
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 7, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 7 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • test_benchmark_detect[reacnetgen_param0] (27.7 ms)
  • test_benchmark_detect[reacnetgen_param1] (75.7 ms)
  • test_benchmark_detect[reacnetgen_param2] (71.9 ms)
  • test_benchmark_hmm[reacnetgen_param0] (245.6 ms)
  • test_benchmark_hmm[reacnetgen_param1] (28.9 ms)
  • test_benchmark_hmm[reacnetgen_param2] (29.3 ms)
  • test_benchmark_hmm[reacnetgen_param3] (244.3 ms)

@njzjz njzjz added this pull request to the merge queue May 7, 2024
Merged via the queue into deepmodeling:master with commit 37b0bef May 7, 2024
20 checks passed
@njzjz njzjz deleted the benchmark branch May 7, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant