Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testing tools NaN comparison and correct new failing tests. #4794

Merged
merged 11 commits into from
Nov 16, 2023
Merged

Fix testing tools NaN comparison and correct new failing tests. #4794

merged 11 commits into from
Nov 16, 2023

Commits on Nov 7, 2023

  1. Initial commit of emstd bug fix and test.

    @lbooker42
    lbooker42 committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    16c7288 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Initial commit of NaN test tooling bug-fix.

    @lbooker42
    lbooker42 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f871ff8 View commit details
    Browse the repository at this point in the history

  2. Merged with main

    @lbooker42
    lbooker42 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    cff18be View commit details
    Browse the repository at this point in the history

  3. Correct post-merge test failure.

    @lbooker42
    lbooker42 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    916946b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Some PR comments addressed

    @lbooker42
    lbooker42 committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    53a0a64 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Numeric class modified to better handle NaN and Inf values, new tests… 

    … to verify standard behavior.
    @lbooker42
    lbooker42 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    43ddf91 View commit details
    Browse the repository at this point in the history

  2. Expanded the NaN and Inf test code to document our expectations.

    @lbooker42
    lbooker42 committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d547db3 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Addressed PR comments.

    @lbooker42
    lbooker42 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    87a50f0 View commit details
    Browse the repository at this point in the history

  2. Added new tests to cover some short circuit behavior.

    @lbooker42
    lbooker42 committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    47d30ff View commit details
    Browse the repository at this point in the history

  3. Update engine/function/src/templates/Numeric.ftl 

    Co-authored-by: Chip Kent <[email protected]>
    @lbooker42 @chipkent
    lbooker42 and chipkent authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    e2b1f18 View commit details
    Browse the repository at this point in the history

  4. Update engine/function/src/templates/Numeric.ftl 

    Co-authored-by: Chip Kent <[email protected]>
    @lbooker42 @chipkent
    lbooker42 and chipkent authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    7bb5e68 View commit details
    Browse the repository at this point in the history