Fix testing tools NaN comparison and correct new failing tests.
#4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbooker42
changed the title
NaN comparison and correct new failing tests.
lbooker42
added
NoDocumentationNeeded
NoReleaseNotesNeeded
rcaudy
reviewed
Nov 8, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
chipkent
reviewed
Nov 8, 2023
engine/table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedVarOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedVarOperator.java
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/DoubleChunkedVarOperator.java
Show resolved
Hide resolved
...src/main/java/io/deephaven/engine/table/impl/updateby/rollingstd/ByteRollingStdOperator.java
Show resolved
Hide resolved
engine/table/src/test/java/io/deephaven/engine/table/impl/updateby/TestRollingProduct.java
Outdated
Show resolved
Hide resolved
...java/io/deephaven/engine/table/impl/updateby/rollingproduct/FloatRollingProductOperator.java
Show resolved
Hide resolved
… to verify standard behavior.
chipkent
reviewed
Nov 15, 2023
chipkent
reviewed
Nov 16, 2023
Co-authored-by: Chip Kent <[email protected]>
Co-authored-by: Chip Kent <[email protected]>
chipkent
approved these changes
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.