Always export scope objects before performing other interactions #11391
Annotations
2 errors and 1 warning
checks
Canceling since a higher priority waiting request for 'Check CI-refs/pull/4816/merge' exists
|
checks
Execution failed for task ':web-client-api:spotlessJavaCheck'.
> The following files had format violations:
src/main/java/io/deephaven/web/client/api/JsTable.java
@@ -1420,8 +1420,7 @@
········typedTicket.setType(JsVariableType.PARTITIONEDTABLE);
········typedTicket.setTicket(partitionedTableTicket);
········Promise<JsPartitionedTable>·fetchPromise·=·new·JsWidget(workerConnection,·typedTicket).refetch().then(
-················widget·->·Promise.resolve(new·JsPartitionedTable(workerConnection,·widget))
-········);
+················widget·->·Promise.resolve(new·JsPartitionedTable(workerConnection,·widget)));
········//·Ensure·that·the·partition·failure·propagates·first,·but·the·result·of·the·fetch·will·be·returned·-·both
········//·are·running·concurrently.
src/main/java/io/deephaven/web/client/api/WorkerConnection.java
@@ -704,7 +704,8 @@
············@OverRide
············public·void·accept(JsVariableChanges·changes)·{
················JsVariableDefinition·foundField·=·changes.getCreated()
-························.find((field,·p1,·p2)·->·field.getTitle().equals(name)·&&·field.getType().equalsIgnoreCase(type));
+························.find((field,·p1,·p2)·->·field.getTitle().equals(name)
+································&&·field.getType().equalsIgnoreCase(type));
················if·(foundField·==·null)·{
····················foundField·=·changes.getUpdated().find((field,·p1,·p2)·->·field.getTitle().equals(name)
@@ -899,7 +900,8 @@
············ExportRequest·req·=·new·ExportRequest();
············req.setSourceId(createTypedTicket(varDef).getTicket());
············req.setResultId(ticket);
-············return·Callbacks.<ExportResponse,·Object>grpcUnaryPromise(c·->·sessionServiceClient().exportFromTicket(req,·metadata(),·c::apply));
+············return·Callbacks.<ExportResponse,·Object>grpcUnaryPromise(
+····················c·->·sessionServiceClient().exportFromTicket(req,·metadata(),·c::apply));
········}),·this);
····}
src/main/java/io/deephaven/web/client/api/impl/TicketAndPromise.java
@@ -7,8 +7,8 @@
import·io.deephaven.web.shared.fu.JsFunction;
/**
-·*·Pair·of·ticket·and·the·promise·that·indicates·it·has·been·resolved.·Tickets·are·usable·before·they·are·resolved,
-·*·but·to·ensure·that·all·operations·completed·successfully,·the·promise·should·be·used·to·handle·errors.
+·*·Pair·of·ticket·and·the·promise·that·indicates·it·has·been·resolved.·Tickets·are·usable·before·they·are·resolved,·but
+·*·to·ensure·that·all·operations·completed·successfully,·the·promise·should·be·used·to·handle·errors.
·*/
public·class·TicketAndPromise<T>·implements·IThenable<T>·{
····private·final·Ticket·ticket;
@@ -40,8 +40,9 @@
····}
····/**
-·····*·Rather·than·waiting·for·the·original·promise·to·succeed,·lets·the·caller·start·a·new·call·based
-·····*·only·on·the·original·ticket.
... (16 more lines that didn't fit)
Run './gradlew :web-client-api:spotlessApply' to fix these violations.
|
checks
Gradle Build Scan: https://gradle.com/s/wbfn2mit5jf56
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
check-ci-results
Expired
|
35.3 MB |
|