Always export scope objects before performing other interactions #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
added
jsapi
plotting
NoDocumentationNeeded
ReleaseNotesNeeded
mofojed
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Looks good to me, tested with my deephaven.ui branch: deephaven/deephaven-plugins#88
Just a basic panel:
from deephaven import ui
@ui.component
def foo():
return ui.flex([])
f = foo()
Opened and closed it, widget closed on panel close, then was able to re-open it without errors.
|
Also confirmed this removes the error when closing the widget for the plotly-express plugin |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensures that widget type strings are checked without regard to case, as the server will also do.
Fixes #4604