Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify get_sequence() and get_sequence_next_value() #16463

Merged
merged 5 commits into from
Sep 18, 2024
Merged

chore: simplify get_sequence() and get_sequence_next_value() #16463

merged 5 commits into from
Sep 18, 2024

Commits on Sep 18, 2024

  1. chore: add test to SequenceIdent

    @drmingdrmer
    drmingdrmer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    467801f View commit details
    Browse the repository at this point in the history

  2. chore: replace manually defined Sequence error with Unknown/Exist E… 

    …rror with generic
    @drmingdrmer
    drmingdrmer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    655500d View commit details
    Browse the repository at this point in the history

  3. refactor: simplify get_sequence() API to return Option instead of Result 

    - Change return type from Result to Option<Sequence>
- Return None when sequence is not found
- This allows callers to easily distinguish between "not found" and other errors
    @drmingdrmer
    drmingdrmer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4048b62 View commit details
    Browse the repository at this point in the history

  4. chore: simplify get_sequence() and get_sequence_next_value()

    @drmingdrmer
    drmingdrmer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8a7d25d View commit details
    Browse the repository at this point in the history

  5. chore: get_sequence() just use the name_ident

    @drmingdrmer
    drmingdrmer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    678d57e View commit details
    Browse the repository at this point in the history