chore: simplify get_sequence() and get_sequence_next_value() #16463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror with generic
- Change return type from Result to Option<Sequence> - Return None when sequence is not found - This allows callers to easily distinguish between "not found" and other errors
github-actions
bot
added
the
pr-chore
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
chore: simplify get_sequence() and get_sequence_next_value()
refactor: simplify get_sequence() API to return Option instead of Result
chore: replace manually defined
Sequenceerror with Unknown/Exist Error with genericchore: add test to
SequenceIdentTests
Type of change
Related Issues
This change is