Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin-1741] SuccessFactors - OAuth2 Implementation #34

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Plugin-1741] SuccessFactors - OAuth2 Implementation #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/SuccessFactors-batchsource.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,21 @@ annotating metadata, etc.
**Use Connection:** Whether to use a connection. If a connection is used, you do not need to provide the credentials.
**Connection:** Name of the connection to use. Entity Names information will be provided by the connection.
You also can use the macro function ${conn(connection-name)}.
**Authentication Type:** Authentication type used to submit request. Supported types are Basic & OAuth 2.0. Default is Basic Authentication.
* **Basic Authentication**
**SAP SuccessFactors Logon Username (M)**: SAP SuccessFactors Logon Username for user authentication.
**SAP SuccessFactors Logon Password (M)**: SAP SuccessFactors Logon password for user authentication.
* **OAuth 2.0**
**Client Id:** Client Id required to generate the token.
**Company Id:** Company Id required to generate the token.
**Assertion Token Type:** Assertion token can be entered or can be created using the required parameters.
* **Enter Token**
**Assertion Token:** Assertion token used to generate the access token.
* **Create Token**
**Token URL:** Token URL to generate the assertion token.
**Private Key:** Private key required to generate the token.
**User Id:** User Id required to generate the token.

**SAP SuccessFactors Base URL (M)**: SAP SuccessFactors Base URL.


Expand Down
17 changes: 14 additions & 3 deletions docs/SuccessFactors-connector.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,20 @@ Properties

**Description:** Description of the connection.

**SAP SuccessFactors Logon Username (M)**: SAP SuccessFactors Logon Username for user authentication.

**SAP SuccessFactors Logon Password (M)**: SAP SuccessFactors Logon password for user authentication.
**Authentication Type:** Authentication type used to submit request. Supported types are Basic & OAuth 2.0. Default is Basic Authentication.
* **Basic Authentication**
**SAP SuccessFactors Logon Username (M)**: SAP SuccessFactors Logon Username for user authentication.
**SAP SuccessFactors Logon Password (M)**: SAP SuccessFactors Logon password for user authentication.
* **OAuth 2.0**
**Client Id:** Client Id required to generate the token.
**Company Id:** Company Id required to generate the token.
**Assertion Token Type:** Assertion token can be entered or can be created using the required parameters.
* **Enter Token**
**Assertion Token:** Assertion token used to generate the access token.
* **Create Token**
**Token URL:** Token URL to generate the assertion token.
**Private Key:** Private key required to generate the token.
**User Id:** User Id required to generate the token.

**SAP SuccessFactors Base URL (M)**: SAP SuccessFactors Base URL.

Expand Down
53 changes: 52 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
<junit.version>4.12</junit.version>
<gcs.client.version>2.0.0</gcs.client.version>
<okhttp3.version>4.9.1</okhttp3.version>
<httpclient.version>4.5.13</httpclient.version>
<apache.olingo.v2>2.0.0</apache.olingo.v2>
<wiremock.version>2.27.2</wiremock.version>
<hydrator.version>2.7.0</hydrator.version>
Expand Down Expand Up @@ -334,7 +335,57 @@
<artifactId>okhttp</artifactId>
<version>${okhttp3.version}</version>
</dependency>
<!-- https://mvnrepository.com/artifact/com.fasterxml.jackson.core/jackson-databind -->
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
<version>${httpclient.version}</version>
</dependency>
<dependency>
<groupId>org.opensaml</groupId>
<artifactId>xmltooling</artifactId>
<version>1.4.4</version>
</dependency>
<dependency>
<groupId>org.opensaml</groupId>
<artifactId>openws</artifactId>
<version>1.5.4</version>
</dependency>
<dependency>
<groupId>org.opensaml</groupId>
<artifactId>opensaml</artifactId>
<version>2.6.4</version>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
<version>1.10</version>
</dependency>
<dependency>
<groupId>xml-security</groupId>
<artifactId>xmlsec</artifactId>
<version>1.3.0</version>
</dependency>
<dependency>
<groupId>commons-collections</groupId>
<artifactId>commons-collections</artifactId>
<version>3.2.2</version>
</dependency>
<dependency>
<groupId>commons-lang</groupId>
<artifactId>commons-lang</artifactId>
<version>2.1</version>
</dependency>
<dependency>
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
<version>1.1</version>
</dependency>
<dependency>
<groupId>org.apache.velocity</groupId>
<artifactId>velocity</artifactId>
<version>1.5</version>
<type>pom</type>
</dependency>
Comment on lines +338 to +388
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are the versions of these dependencies decided?

Is the same code being used somewhere in any other existing plugin?

Please add comments for every dependency where it is used.

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
Expand Down
Loading