[Plugin-1741] SuccessFactors - OAuth2 Implementation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubhangi-cs
force-pushed
the
Oauth2_Implementation
branch
from
37869a0
to
4083f5d
Compare
Shubhangi-cs
force-pushed
the
Oauth2_Implementation
branch
from
ed6fb11
to
6989161
Compare
| @@ -0,0 +1,391 @@ | |||
| /* | |||
| * Copyright © 2022 Cask Data, Inc. | |||
There was a problem hiding this comment.
please update year in the license.
Comment on lines
+338
to
+388
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| <version>${httpclient.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.opensaml</groupId> | ||
| <artifactId>xmltooling</artifactId> | ||
| <version>1.4.4</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.opensaml</groupId> | ||
| <artifactId>openws</artifactId> | ||
| <version>1.5.4</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.opensaml</groupId> | ||
| <artifactId>opensaml</artifactId> | ||
| <version>2.6.4</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>commons-codec</groupId> | ||
| <artifactId>commons-codec</artifactId> | ||
| <version>1.10</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>xml-security</groupId> | ||
| <artifactId>xmlsec</artifactId> | ||
| <version>1.3.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>commons-collections</groupId> | ||
| <artifactId>commons-collections</artifactId> | ||
| <version>3.2.2</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>commons-lang</groupId> | ||
| <artifactId>commons-lang</artifactId> | ||
| <version>2.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>commons-logging</groupId> | ||
| <artifactId>commons-logging</artifactId> | ||
| <version>1.1</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.velocity</groupId> | ||
| <artifactId>velocity</artifactId> | ||
| <version>1.5</version> | ||
| <type>pom</type> | ||
| </dependency> |
There was a problem hiding this comment.
How are the versions of these dependencies decided?
Is the same code being used somewhere in any other existing plugin?
Please add comments for every dependency where it is used.
Comment on lines
+103
to
+105
| "property": "authType", | ||
| "operator": "equal to", | ||
| "value": "basicAuth" |
There was a problem hiding this comment.
authType will be null in existing pipelines since it is a newly added config.
We should default to basicAuth when authType is also null.
Comment on lines
+416
to
+418
| tokenURL, clientId, privateKey, userId, samlUsername, assertionToken, | ||
| companyId, authType, assertionTokenType, filterOption, selectOption, | ||
| expandOption, additionalQueryParameters, paginationType); |
There was a problem hiding this comment.
indentation looks off here.
Comment on lines
+162
to
+174
| if (config.getConnection().getAuthType().equals(SuccessFactorsConnectorConfig.BASIC_AUTH)) { | ||
| failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsPluginConfig.UNAME); | ||
| failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsPluginConfig.PASSWORD); | ||
| } else { | ||
| failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsConnectorConfig.COMPANY_ID); | ||
| failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsConnectorConfig.CLIENT_ID); | ||
| if (config.getConnection().getAssertionTokenType().equals(SuccessFactorsConnectorConfig.ENTER_TOKEN)) { | ||
| failureCollector.addFailure(errMsg, null). | ||
| withConfigProperty(SuccessFactorsConnectorConfig.ASSERTION_TOKEN); | ||
| } else { | ||
| failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsConnectorConfig.PRIVATE_KEY); | ||
| failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsConnectorConfig.USER_ID); | ||
| failureCollector.addFailure(errMsg, null).withConfigProperty(SuccessFactorsConnectorConfig.TOKEN_URL); |
There was a problem hiding this comment.
constants should always be used first in java to avoid NPE in equals condition.
For example,
if (SuccessFactorsConnectorConfig.BASIC_AUTH.equals(config.getConnection().getAuthType())) {....}
Comment on lines
+370
to
+371
| this.authType = authType; | ||
| return this; |
There was a problem hiding this comment.
authType will be null for existing pipelines.
It should default to BASIC_AUTH in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Oauth 2.0 support in SAP Successfactors Batch Source Plugin. SAP SuccessFactors supports OAuth 2.0 to authenticate OData API and SFAPI users. Compared with HTTP Basic Auth, OAuth 2.0 is considered to be more secure in that it doesn't require users to provide their passwords during authentication. With OAuth 2.0, you can also use a third-party identity provider (IDP) for user management and provisioning.
https://cdap.atlassian.net/browse/PLUGIN-1741