wasm: support http(s) fetch of Wasm files

bindings/wasm/output.go

@@ -16,6 +16,7 @@ package wasm
 import (
 	"bytes"
 	"context"
+	"encoding/csv"
 	"fmt"
 	"io"
 	"reflect"
@@ -63,9 +64,10 @@ func NewWasmOutput(logger logger.Logger) bindings.OutputBinding {
 }
 
 func (out *outputBinding) Init(ctx context.Context, metadata bindings.Metadata) (err error) {
-	if out.meta, err = wasm.GetInitMetadata(metadata.Base); err != nil {
+	if out.meta, err = wasm.GetInitMetadata(ctx, metadata.Base); err != nil {
 		return fmt.Errorf("wasm: failed to parse metadata: %w", err)
 	}
+	//	ctx = context.WithValue(ctx, experimental.FunctionListenerFactoryKey{}, logging.NewHostLoggingListenerFactory(os.Stderr, logging.LogScopeAll))
 
 	// Create the runtime, which when closed releases any resources associated with it.
 	out.runtime = wazero.NewRuntimeWithConfig(ctx, out.runtimeConfig)
@@ -115,7 +117,13 @@ func (out *outputBinding) Invoke(ctx context.Context, req *bindings.InvokeReques
 
 	// Get any remaining args from configuration
 	if args := req.Metadata["args"]; args != "" {
-		argsSlice = append(argsSlice, strings.Split(args, ",")...)
+		parser := csv.NewReader(strings.NewReader(args))
+		parser.Comma = ' '
+		records, err := parser.ReadAll()
+		if err != nil {
+			return nil, err
+		}
+		argsSlice = append(argsSlice, records[0]...)
 	}
 	moduleConfig = moduleConfig.WithArgs(argsSlice...)
 

bindings/wasm/output_test.go

@@ -28,6 +28,7 @@ import (
 )
 
 const (
+	ruby           = "https://github.com/vmware-labs/webassembly-language-runtimes/releases/download/ruby%2F3.2.0%2B20230215-1349da9/ruby-3.2.0-slim.wasm"
 	urlArgsFile    = "file://testdata/args/main.wasm"
 	urlExampleFile = "file://testdata/example/main.wasm"
 	urlLoopFile    = "file://testdata/loop/main.wasm"
@@ -116,10 +117,11 @@ func Test_Invoke(t *testing.T) {
 		},
 		{
 			name: "args",
-			url:  urlArgsFile,
+			url:  ruby,
 			request: &bindings.InvokeRequest{
-				Metadata:  map[string]string{"args": "1,2"},
+				Metadata:  map[string]string{"args": "-ne 'print \"Hello \";print '"},
 				Operation: ExecuteOperation,
+				Data:      []byte("salaboy"),
 			},
 			expectedData: "main\n1\n2",
 		},

internal/wasm/http.go

@@ -41,15 +41,18 @@ func newHTTPCLient(transport http.RoundTripper) *httpClient {
 // fetch returns a byte slice of the wasm module found at the given URL, or an error otherwise.
 func (f *httpClient) get(ctx context.Context, u *url.URL) ([]byte, error) {
 	h := http.Header{}
-	// Clear default user agent.
-	h.Set("User-Agent", "")
-	req := &http.Request{Method: http.MethodGet, URL: u, Header: h}
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, u.String(), nil)
+	if err != nil {
+		return nil, err
+	}
+	req.Header = h
 	resp, err := f.c.Do(req.WithContext(ctx))
 	if err != nil {
 		return nil, err
 	}
 
 	if resp.StatusCode != http.StatusOK {
+		io.Copy(io.Discard, resp.Body)
 		resp.Body.Close()
 		return nil, fmt.Errorf("received %v status code from %q", resp.StatusCode, u)
 	}
@@ -58,6 +61,7 @@ func (f *httpClient) get(ctx context.Context, u *url.URL) ([]byte, error) {
 	if err != nil {
 		return nil, err
 	}
+	io.Copy(io.Discard, resp.Body)
 	resp.Body.Close()
 	return bytes, nil
 }

internal/wasm/wasm.go

@@ -67,7 +67,7 @@ type InitMetadata struct {
 }
 
 // GetInitMetadata returns InitMetadata from the input metadata.
-func GetInitMetadata(md metadata.Base) (*InitMetadata, error) {
+func GetInitMetadata(ctx context.Context, md metadata.Base) (*InitMetadata, error) {
 	// Note: the ctx will be used for other schemes such as HTTP and OCI.
 
 	var m InitMetadata
@@ -95,7 +95,7 @@ func GetInitMetadata(md metadata.Base) (*InitMetadata, error) {
 			return nil, err
 		}
 		c := newHTTPCLient(http.DefaultTransport)
-		m.Guest, err = c.get(context.Background(), u)
+		m.Guest, err = c.get(ctx, u)
 		if err != nil {
 			return nil, err
 		}

internal/wasm/wasm_test.go

@@ -38,6 +38,9 @@ const (
 var binArgs []byte
 
 func TestGetInitMetadata(t *testing.T) {
+	testCtx, cancel := context.WithCancel(context.Background())
+	t.Cleanup(cancel)
+
 	type testCase struct {
 		name        string
 		metadata    metadata.Base
@@ -137,7 +140,7 @@ func TestGetInitMetadata(t *testing.T) {
 	for _, tt := range tests {
 		tc := tt
 		t.Run(tc.name, func(t *testing.T) {
-			md, err := GetInitMetadata(tc.metadata)
+			md, err := GetInitMetadata(testCtx, tc.metadata)
 			if tc.expectedErr == "" {
 				require.NoError(t, err)
 				require.Equal(t, tc.expected, md)

middleware/http/wasm/httpwasm.go

@@ -36,7 +36,7 @@ func (m *middleware) GetHandler(ctx context.Context, metadata dapr.Metadata) (fu
 
 // getHandler is extracted for unit testing.
 func (m *middleware) getHandler(ctx context.Context, metadata dapr.Metadata) (*requestHandler, error) {
-	meta, err := wasm.GetInitMetadata(metadata.Base)
+	meta, err := wasm.GetInitMetadata(ctx, metadata.Base)
 	if err != nil {
 		return nil, fmt.Errorf("wasm: failed to parse metadata: %w", err)
 	}