-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm: support http(s) fetch of Wasm files #3005
Conversation
Optionally, the response may compressed Signed-off-by: Edoardo Vacchi <[email protected]>
/cc @codefromthecrypt FYI |
bikeshed as code looks good to me.
fetch is a browser term and doesnt clarify anything here. maybe rename more direct? from httpFetch to httpGet and the file to http.go
glad to know go conveniently implements what we need for compression and thanks for the docs.
|
Thanks! LGTM overall.
|
Signed-off-by: Edoardo Vacchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I accidentally didn't submit my reivew. Overall LGTM but some comments
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
Thanks! Will merge when tests pass |
Signed-off-by: Edoardo Vacchi <[email protected]>
Head branch was pushed to by a user without write access
some changes were committed by mistake (arg handling), those I may revisit separately in another PR. Thanks for your patience @ItalyPaleAle |
Extends the current plugin config to use instead a URI. In the case of `file://` the behavior is the same as it is currently. In the case of `http(s)://` it will fetch the URI and try to evaluate it as a wasm payload. This PR is based on earlier work on `dapr/component-contrib`. See: dapr/components-contrib#3005 Signed-off-by: Edoardo Vacchi <[email protected]>
Extends the current plugin config to use instead a URI. In the case of `file://` the behavior is the same as it is currently. In the case of `http(s)://` it will fetch the URI and try to evaluate it as a wasm payload. This PR is based on earlier work on `dapr/component-contrib`. See: dapr/components-contrib#3005 Signed-off-by: Edoardo Vacchi <[email protected]>
Extends the current plugin config to use instead a URI. In the case of `file://` the behavior is the same as it is currently. In the case of `http(s)://` it will fetch the URI and try to evaluate it as a wasm payload. This PR is based on earlier work on `dapr/component-contrib`. See: dapr/components-contrib#3005 Signed-off-by: Edoardo Vacchi <[email protected]>
Extends the current plugin config to use instead a URI. In the case of `file://` the behavior is the same as it is currently. In the case of `http(s)://` it will fetch the URI and try to evaluate it as a wasm payload. This PR is based on earlier work on `dapr/component-contrib`. See: dapr/components-contrib#3005 Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi [email protected]
Description
We add support to simple HTTP(S) fetch of (optionally compressed) Wasm files; i.e. not tarballs, but compressed responses from an HTTP(S) server. Will update docs later, opening draft in the meantime, for early feedback.
Issue reference
This addresses issue #2700 without closing, because we don't support tar.gz files yet.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: