-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow group override global node connectivity check #623
Conversation
非常感谢你的贡献,代码质量看起来很不错 |
@mzz2017 上述提及的代码均已按建议修改,请再次review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
等待第三方测试后合入 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪 Since the PR has been fully tested, please consider merging it.
测试一切正常,能正常工作 |
@mzz2017 @KagurazakaNyaa 应用这个pr后编译基于此版本dae的daed,会导致daed更新订阅出错,无法获取到节点 |
看了一下报错在 https://github.com/KagurazakaNyaa/dae/blob/d8fad755979e87fdb448eead497a650a18a23cf1/component/outbound/dialer/dialer.go#L101 似乎是打日志的时候引用了空指针 |
@KagurazakaNyaa 应该是 daed 在 new dialer 的时候没有传入 property,而是传的空指针导致的,要改一下 dae-wing |
…e#623) Co-authored-by: mzz2017 <[email protected]>
@mzz2017 dae/component/outbound/dialer/dialer.go Line 101 in cec5e71
|
@wanlce 可否帮忙修一下? |
Background
此Pull Request允许group配置覆盖global配置中的节点联通性检查以支持更加灵活的场景
Checklist
Full Changelogs
Issue Reference
Closes #619
Test Result
测试环境
Archlinux
$ uname -a Linux secops 6.10.8-zen1-1-zen #1 ZEN SMP PREEMPT_DYNAMIC Wed, 04 Sep 2024 15:18:31 +0000 x86_64 GNU/Linux
构建
测试
未更改原有配置的情况下,systemd启动服务正常运行
执行
sudo /usr/bin/dae validate -c /etc/dae/config.dae
返回值0修改配置后,
systemctl restart dae.service
主要变更的配置
检查日志
且proxy组没有此日志
代理正常运行
内存使用情况
修改配置添加
重启后内存使用没有显著增加