Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should pass Logger to dialer to avoid nil #157

Merged
merged 2 commits into from
Sep 28, 2024
Merged

fix: should pass Logger to dialer to avoid nil #157

merged 2 commits into from
Sep 28, 2024

Conversation

wanlce
Copy link
Contributor

@wanlce wanlce commented Sep 21, 2024

Background

daeuniverse/dae#623 (comment)

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Fix #[issue number]

Test Result

@wanlce wanlce requested a review from a team as a code owner September 21, 2024 15:11
mzz2017
mzz2017 reviewed Sep 22, 2024
View reviewed changes
db/node_utils.go Outdated Show resolved Hide resolved
dae-prow[bot]
dae-prow bot approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 13bca2d into main Sep 28, 2024
3 checks passed
@mzz2017 mzz2017 deleted the wano/fix_add_sub branch September 28, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

@mzz2017 mzz2017 mzz2017 approved these changes

Assignees

@wanlce wanlce

Labels
fix tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanlce @mzz2017