-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cuesheet v2 #435
Conversation
Hi @asharonbaltazar , hoping to ask for some help here: I am working on rebuilding the current I am slightly stunned on finding a good solution for optimising the table here, in the current PR I have attempted to use react-virtual (also tanstack) since it seemed efficient and lightweight In the rundown view we use In terms of specification, the expectation here is that users would have slightly under 1000 elements in the table and will want the fastest experience in re-renders possible. Initial render time is less problematic Any thoughts? |
the ux with react-virtual was not great, the library is due a major release so we will try again later
Ack. Taking a look later today 👀 |
apps/client/src/features/table/table-settings/TableSettings.tsx
Outdated
Show resolved
Hide resolved
hahaha, no need to apologise. The question above was unrelated to the padding changes, I should have been the one to be more specific :D |
Nah, it looks cleaner than the old one. I'm wondering if the old one would look better if you fade the subsequent rows' color a bit... Sorta like the contrast in these buttons |
This PR aims to redesign the cuesheet to the new system
It should also add row virtualisation to improve performance on handling several hundreds of items
TODO: