Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change colour of last event #125

Closed
Keksstar opened this issue May 21, 2022 · 9 comments · Fixed by #386
Closed

Change colour of last event #125

Keksstar opened this issue May 21, 2022 · 9 comments · Fixed by #386
Labels
improvement Improvement on existing feature

Comments

@Keksstar
Copy link

Would be great if the colour of the last "played" event could be changed, like change it to gray or similar. This could come in handy for the cuesheet as you normally don´t care about the past. It´s more interesting what comes up next...
Gives more clear visual indication of where you are.

Btw: Congrats to V1 :-)

@cpvalente
Copy link
Owner

Thank you for you comment and for your involvement.
This can definitely be part of #55 but I wonder if it should be optional behaviour?
I know some users use ontime just a timer generator, so they would make a Qlist like

  • 1 min timer
  • 5 min timer
  • 10 min timer

and from there use OSC to control these. In this case there is no sense on a before / after.
Also ontime doesnt really care about the order of the events, but about the start time.

Either way this is a good suggestion and I believe it can go a long way on user experience. I will take a look

@cpvalente cpvalente added the improvement Improvement on existing feature label May 21, 2022
@Keksstar
Copy link
Author

Definitly a good part for #55 - Thanks for adding this!

@cpvalente
Copy link
Owner

Hi @Keksstar , is this issue still relevant in v2?

@Keksstar
Copy link
Author

Sure, it's still present.

@cpvalente
Copy link
Owner

Hi @Keksstar , with the release of beta-6 we have made it so that all events previous to the loaded event are faded out.

Having fade apply to the event immediately before is something we need to calculate and we felt it doesn't provide enough value for the trade off.

I will eventually close this issue but am still hoping to get your feedback ion the implementation

@cpvalente cpvalente linked a pull request May 21, 2023 that will close this issue
Merged
@Keksstar
Copy link
Author

Looks great in ontime. Sadly it´s not reflected to the Cuesheet. Would be great if this can be added there as well.

@cpvalente
Copy link
Owner

I believe this has been sufficiently handled in #435

@Keksstar
Copy link
Author

I can´t see any difference in the Cuesheet. It´s still present there. It doesn´t show the same behaviour as the software itself.

@cpvalente
Copy link
Owner

I can´t see any difference in the Cuesheet. It´s still present there. It doesn´t show the same behaviour as the software itself.

The new cuesheet is not yet deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement on existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants