Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(atomic): clear min/max for atomic-timeframe-facet when clearing filters #4240

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fix(atomic): clear min/max for atomic-timeframe-facet when clearing filters #4240

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fae3c7
fix for facet date input reset
fpbrault Jul 30, 2024
7dcbb1f
add tests
fpbrault Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/atomic/src/components/common/facets/facet-date-input/facet-date-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ export class FacetDateInput {
this.start = range ? parseDate(range.start).toDate() : undefined;
this.end = range ? parseDate(range.end).toDate() : undefined;
}
public componentDidUpdate() {
if (!this.startRef.value && !this.endRef.value) {
this.startRef.min = this.min || this.formattedDateValue('1401-01-01');
this.endRef.max = this.max || '';
this.startRef.max = this.max || '';
this.endRef.min = this.min || '';
}
}

private apply() {
if (!this.startRef.validity.valid || !this.endRef.validity.valid) {
Expand Down Expand Up @@ -138,7 +146,7 @@ export class FacetDateInput {
placeholder={placeholder}
pattern={pattern}
required
min={this.min || this.formattedDateValue(this.start)}
min={this.formattedDateValue(this.start) || this.min}
max={this.max}
value={this.formattedDateValue(range?.end)}
onInput={(e) =>
Expand Down
Loading