Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): clear min/max for atomic-timeframe-facet when clearing filters #4240

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

fpbrault
Copy link
Contributor

This PR ensures that the min/max attributes of the atomic-timeframe-facet date input get reset correctly when clearing the filters.

https://coveord.atlassian.net/browse/KIT-3448

Copy link

github-actions bot commented Jul 30, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.1 244.1 0
commerce 340.6 340.6 0
search 413.8 413.8 0
insight 391.5 391.5 0
product-listing 306.2 306.2 0
product-recommendation 210.4 210.4 0
recommendation 257.2 257.2 0
ssr 404.4 404.4 0
ssr-commerce 337.6 337.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

alexprudhomme

This comment was marked as resolved.

Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test covering this case ?

@fpbrault fpbrault added this pull request to the merge queue Jul 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 31, 2024
@fpbrault fpbrault added this pull request to the merge queue Jul 31, 2024
Merged via the queue into master with commit d97b04d Jul 31, 2024
111 checks passed
@fpbrault fpbrault deleted the KIT-3448 branch July 31, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants