Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route attributes - MTU, AdvMSS, Priority #1041

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

alopintsev
Copy link
Contributor

@alopintsev alopintsev commented Nov 20, 2023

Extend route attributes to make route selection available based on route priority and enable per-route MTU settings.
It's will be helpfull in multi-CNI environment, and networks, that support jumbo-frame.

Fixes: #1004

@alopintsev alopintsev force-pushed the add-route-attributes branch 2 times, most recently from e931118 to 7f3da24 Compare November 21, 2023 20:44
@squeed
Copy link
Member

squeed commented Nov 27, 2023

@alopintsev looks reasonable. However, we will need to update the specification as well, as these are defined types. Thanks!

@coveralls
Copy link

coveralls commented Nov 27, 2023

Coverage Status

coverage: 71.566% (-0.007%) from 71.573%
when pulling 4a0bccb on alopintsev:add-route-attributes
into 93878e6 on containernetworking:main.

@alopintsev
Copy link
Contributor Author

@alopintsev looks reasonable. However, we will need to update the specification as well, as these are defined types. Thanks!

I've made changes in specification, would you mind to check it?

Copy link
Member

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@squeed
Copy link
Member

squeed commented Dec 5, 2023

FYI @aojea / @Joffref, who had also looked at this.

@aojea
Copy link

aojea commented Dec 5, 2023

LGTM

@squeed squeed requested a review from mccv1r0 December 11, 2023 16:40
@squeed squeed merged commit 66c292a into containernetworking:main Dec 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MTU as a Route property
4 participants