Add MTU field to route type definition #1005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: containernetworking#1004 Signed-off-by: Joffref <[email protected]>
aojea
reviewed
Jul 4, 2023
aojea
reviewed
Jul 4, 2023
squeed
reviewed
Aug 7, 2023
pkg/types/020/types_test.go
Outdated
| @@ -53,14 +53,14 @@ func testResult(resultCNIVersion, jsonCNIVersion string) (*types020.Result, stri | |||
| IP: *ipv4, | |||
| Gateway: net.ParseIP("1.2.3.1"), | |||
| Routes: []types.Route{ | |||
| {Dst: *routev4, GW: routegwv4}, | |||
| {Dst: *routev4, GW: routegwv4, MTU: 1024}, | |||
There was a problem hiding this comment.
We should probably not add any new fields to v0.2.0 and v0.4.0 -- what do you think, @dcbw ?
There was a problem hiding this comment.
Should I remove new fields inside v0.2.0 and v0.4.0, while updating SPEC.md?
There was a problem hiding this comment.
@Joffref yes please.
(Sorry, I somehow missed your question!)
|
This looks basically good. We also need to describe this in SPEC.md. Shouldn't be more than a line or two needed. |
Signed-off-by: Joffref <[email protected]>
Signed-off-by: Joffref <[email protected]>
Signed-off-by: Joffref <[email protected]>
aojea
reviewed
Oct 23, 2023
| @@ -17,13 +17,13 @@ package types020_test | |||
| import ( | |||
| "encoding/json" | |||
| "fmt" | |||
| types020 "github.com/containernetworking/cni/pkg/types/020" | |||
|
Added in #1041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1004