Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] Bump to 1.2.0b2 #67

Closed
wants to merge 2 commits into from
Closed

[DEV] Bump to 1.2.0b2 #67

wants to merge 2 commits into from

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jul 8, 2022

Upstream diff

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@maresb maresb requested review from ocefpaf and xylar as code owners July 8, 2022 07:01
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@maresb
Copy link
Contributor Author

maresb commented Jul 8, 2022

@conda-forge-admin, please rerender

@xylar xylar changed the title Bump to 1.2.0b2 [DEV] Bump to 1.2.0b2 Jul 8, 2022
Copy link
Contributor

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me! Thanks @maresb!

@xylar
Copy link
Contributor

xylar commented Jul 8, 2022

Hmm, it looks like poetry-plugin-export depends on poetry
https://github.com/conda-forge/poetry-plugin-export-feedstock/blob/main/recipe/meta.yaml#L21
and this version of poetry depends on poetry-plugin-export

- poetry-plugin-export >=1.0.4,<2.0.0

Such circular dependencies are allowed on pypi but not in conda packages.

The other problem is that I don't know how well it will work for a non-dev package (poetry-plugin-export) to require a dev package (this poetry).

@maresb
Copy link
Contributor Author

maresb commented Jul 8, 2022

Yes, this is the same circular dependency I was complaining about in #65.

What do you mean by a "non-dev" package? At least the label for poetry-plugin-export is poetry_dev.

Maybe I should complain upstream about the circular dependency.

@maresb
Copy link
Contributor Author

maresb commented Jul 8, 2022

It looks like the build is failing due to some missing packages.

@xylar
Copy link
Contributor

xylar commented Jul 8, 2022

I noticed after the fact that poetry-plugin-export was on poetry_dev so that's fine. That's probably necessary for any package that has a dependency on a *_dev label.

@xylar
Copy link
Contributor

xylar commented Jul 8, 2022

Yes, the missing dependencies need to be built (or the recipes added) but the one that has me worried is:

package poetry-plugin-export-1.0.4-pyhc6ef2e2_0 requires poetry >=1.2.0b1dev0,<2.0.0, but none of the providers can be installed

I don't see any way to fix this unless poetry-plugin-export can be made to depend on poetry-core instead of poetry. So, yes, I think you (we) probably need to complain upstream.

@maresb
Copy link
Contributor Author

maresb commented Jul 8, 2022

Hmm, good point. These circular dependencies are very confusing. Conda tries to set up an environment for building Poetry, installs poetry-plugin-export as a dependency, and then ends up installing Poetry itself as a subdependency. I don't know much about the implementation details of Conda, but this does indeed seem very bad.

@maresb
Copy link
Contributor Author

maresb commented Jul 13, 2022

WIP for missing platformdirs:
conda-forge/platformdirs-feedstock#11

@maresb
Copy link
Contributor Author

maresb commented Jul 13, 2022

platformdirs is complete

@maresb maresb closed this Jul 13, 2022
@maresb maresb reopened this Jul 13, 2022
@maresb maresb closed this Jul 14, 2022
@maresb maresb reopened this Jul 14, 2022
@maresb
Copy link
Contributor Author

maresb commented Jul 14, 2022

The remaining dependencies seem to now be in order. The circular dependency is still problematic. Hopefully something will happen with python-poetry/poetry#5980

@xylar xylar mentioned this pull request Aug 30, 2022
4 tasks
@xylar
Copy link
Contributor

xylar commented Aug 31, 2022

closed via #71

@xylar xylar closed this Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants