Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclic dependency between poetry and poetry-plugin-export #6441

Closed
maresb opened this issue Jul 8, 2022 · 5 comments · Fixed by #5980
Closed

Cyclic dependency between poetry and poetry-plugin-export #6441

maresb opened this issue Jul 8, 2022 · 5 comments · Fixed by #5980
Labels
area/plugin-api Related to plugins/plugin API

Comments

@maresb
Copy link

maresb commented Jul 8, 2022

poetry-plugin-export v1.0.4 (and earlier) depends on poetry = "^1.2.0b1dev0".

Poetry 1.2.0b2 introduces a dependency on poetry-plugin-export = "^1.0.4".

While this might not be immediately problematic, ideally the directed dependencies graph should remain acyclic. This is already causing trouble in conda-forge/poetry-feedstock#67.

@xylar
Copy link

xylar commented Jul 8, 2022

As I said in the conda PR, pip and pypi allow circular dependencies but conda does not. So a circular dependency would mean conda packages couldn't be built with the latest poetry.

@dimbleby
Copy link
Contributor

dimbleby commented Jul 9, 2022

While I agree with you that the cyclic dependency is undesirable, I think you've raised it in the wrong repository.

  • The plugin definitely always needs to rely on poetry, no fix can be made here
  • poetry relying on the plugin is I think the mistake. IIUC this is aimed at providing backwards compatibility for the poetry export command: but too bad!

@xylar
Copy link

xylar commented Jul 9, 2022

@dimbleby, thanks very much for opening the PR in poetry.

@xylar
Copy link

xylar commented Apr 16, 2024

Just a note to say that I think we can actually handle circular dependencies on conda-forge, it's just a bit awkward. If the circular dependencies can't be satisfied for either package with existing package builds, we have to do a build of one or the other package without the circular dependency and then another build with it. It's not elegant but it works. So we may be able to close this issue.

@Secrus Secrus linked a pull request Sep 26, 2024 that will close this issue
Copy link

github-actions bot commented Nov 5, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/plugin-api Related to plugins/plugin API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants