FIX: pin back modestimage's dependency on numpy to avoid removal #465
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| @@ -902,6 +902,13 @@ def _gen_new_index_per_key(repodata, subdir, index_key): | |||
| i = record['depends'].index('python >=3.6') | |||
| record['depends'][i] = 'python >=3.7' | |||
|
|
|||
| # Need to patch modest image for numpy 1.24 removal of np.float | |||
| if ( | |||
| record_name == "modestimage" and record['version'] == '0.2' and record['build'] in {'pyhd8ed1ab_0', 'pyhd8ed1ab_1' } | |||
There was a problem hiding this comment.
It is probably an overkill b/c you are already patching specific build hashes but do you mind adding a and record.get('timestamp', 0) < timestamp here to avoid patching future incarnations of this.
There was a problem hiding this comment.
Done (I think?) I just the int version of time.time() for the value, not sure if that is correct or not.
There was a problem hiding this comment.
We suggest python -c "import time; print(f'{time.time():.0f}000')" in the PR template to keep the numbers consistent.
There was a problem hiding this comment.
I did something wildly wrong then as my time is 3 orders of magnitude smaller than the other numbers....
There was a problem hiding this comment.
I did something wrong b/c I did not check it properly ;-p
No more merging on the cellphone for me :-)
Checklist
python show_diff.pyand posted the output as part of the PR.conda-forge/modestimage-feedstock#4 is PR to patch the feedstock.