Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: temporarily pin numpy back to unbreak modestimage #67

Closed
wants to merge 1 commit into from

Conversation

tacaswell
Copy link
Member

working on fixing modest image, short-term fix.

Copy link
Collaborator

@XYangXRay XYangXRay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regular numpy version update. everything seems good.

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be needed. Instead, you could add a minimum pin for the modestimage package as >=0.2=*_2 as it was just published to https://anaconda.org/conda-forge/modestimage/files (based on conda-forge/modestimage-feedstock#4) to ensure the version with the fix is selected.

@tacaswell
Copy link
Member Author

I agree, was not sure which would be faster (getting the package rebuilt with the patch or this approach).

I think now that a patched modestimage is available we just need to rebuild the image?

@mrakitin
Copy link
Member

mrakitin commented Jun 8, 2023

Yes, that will fix it. As I suggested above, we'd need a minimum pin for modestimage.

@tacaswell
Copy link
Member Author

We should not need to pin as conda-forge/conda-forge-repodata-patches-feedstock#466 and conda-forge/conda-forge-repodata-patches-feedstock#465 should patch CF's metadata so that the existing modestimage builds claim to have an upper bound on of np < 1.24

@tacaswell tacaswell closed this Jun 8, 2023
@tacaswell tacaswell deleted the pin_numpy branch June 8, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants