Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use suitesparse on Windows #10

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Use suitesparse on Windows #10

merged 3 commits into from
Oct 29, 2020

Conversation

berkels
Copy link
Contributor

@berkels berkels commented Oct 29, 2020

Using suitesparse on windows seems to be a bit of pain. In case someone is keen to tackle it, the recipe https://github.com/conda-forge/ceres-solver-feedstock may be a good example (conda-forge/ceres-solver-feedstock#10).

@berkels
Copy link
Contributor

berkels commented Oct 25, 2020

Some further information: The Windows version of quocmesh was only ever combined with the following SuiteSparse variant: https://github.com/jlblancoc/suitesparse-metis-for-windows. It's possible that our CMakeLists.txt and/or our FindSuiteSparse.cmake needs to be updated to work with conda's SuiteSparse.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ericpre
Copy link
Member Author

ericpre commented Oct 29, 2020

The package built in c58b73d have been uploaded to anaconda cloud because this branch is not from a fork. See the first note in https://conda-forge.org/docs/maintainer/updating_pkgs.html#forking-and-pull-requests.
@berkels: you need to make PRs from your own fork, if not, each push will upload a package (when the build pass!).

Other than that, nice to see the support for suitesparse being added on windows! 👍

@berkels
Copy link
Contributor

berkels commented Oct 29, 2020

Thanks for the info! I'll be sure to use a fork next time. I'm still getting started with creating/maintaining conda-forge feedstocks.

@berkels berkels merged commit 587f761 into master Oct 29, 2020
@jan-janssen jan-janssen deleted the SuiteSparseWin branch October 29, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants