Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update InterOp builds to Ubuntu 24.04 #290

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

aaronj0
Copy link
Collaborator

@aaronj0 aaronj0 commented May 18, 2024

Meant to fix #265

The CI seems to be picking up cppyy-cling from master when the backend install fails and uses an include RTypes.h used for ROOT. Specifically strlcpy.h which was copied to fix issues with Clang parsing gcc headers. These are BSD only string functions and not part of any standard, and declared in cling/src/core/clib:

#ifndef ROOT_strlcpy
#define ROOT_strlcpy

#include <ROOT/RConfig.hxx>
#ifdef __cplusplus
extern "C" {
#endif

size_t strlcpy(char *dst, const char *src, size_t siz);
size_t strlcat(char *dst, const char *src, size_t siz);

#ifdef __cplusplus
}

Ideally we should update the header guards for ubuntu 24 but in our case we don't use cppyy-cling, nor does our fork have those files. pip defaults to downloading and using the tarball for upstream cppyy-backend which causes this mess. Defaulting to cmake could fix this

@mcbarton
Copy link
Collaborator

@maximusron If this works you'll want to wipe the cache the cache this PR made before merging, and delete the Ubuntu cache on the main too.

@mcbarton
Copy link
Collaborator

@maximusron can you link this PR to #265 ?

@aaronj0
Copy link
Collaborator Author

aaronj0 commented May 19, 2024

@maximusron can you link this PR to #265 ?

Yeah sure, this PR was meant to just fix the cppyy-backend issue but if this works then maybe we can just upgrade the ubuntu versions with this. Ideally we shouldn't have to change anything on the cppyy-backend side but I am still investigating that

@mcbarton
Copy link
Collaborator

@maximusron Is the commit where you removed -DLLVM_ENABLE_WERROR=On temporary while you debug this PR?

@aaronj0
Copy link
Collaborator Author

aaronj0 commented May 22, 2024

@mcbarton yep its temporary, but we have another set of warnings that emerge on ubuntu 24 that we need to fix. On this PR, I removed it since we would error out on the build CppInterOp step. This may happen everytime we change the os/platform/gcc/clang

@vgvassilev
Copy link
Contributor

@mcbarton yep its temporary, but we have another set of warnings that emerge on ubuntu 24 that we need to fix. On this PR, I removed it since we would error out on the build CppInterOp step. This may happen everytime we change the os/platform/gcc/clang

Yes, and as part of this change we will fix them. Otherwise people commit stuff with warnings which are actually real issues...

@aaronj0
Copy link
Collaborator Author

aaronj0 commented May 22, 2024

@vgvassilev yes I have only removed it fix the pypi issue, theres something in the pyproject.toml file that needs to be changed for no-pep to work. Once that worked I thought we can fix the new warnings before merging

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@mcbarton
Copy link
Collaborator

@maximusron The ci won't run on this PR until you have resolve the merge conflicts

@aaronj0 aaronj0 force-pushed the maximusron/ubu24 branch 3 times, most recently from 13d251f to 3cd3df4 Compare May 30, 2024 10:20
@aaronj0 aaronj0 added the ci CI workflows label May 30, 2024
@aaronj0 aaronj0 force-pushed the maximusron/ubu24 branch 3 times, most recently from 0fedf6b to 40a2528 Compare August 22, 2024 08:12
@aaronj0 aaronj0 changed the title Fix cppyy-backend installation with ubuntu 24 [ci] Update InterOp builds to Ubuntu 24.04 Aug 22, 2024
…late parameters warning

This is to suppress a bogus warning(and therefore error) on the CI while migrating to Ubuntu 24. See ARM-software/ComputeLibrary#330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 24.04 support ci
4 participants