Added pull_request_template.md #299
Conversation
.github/pull_request_template.md
Outdated
| - [ ] I have made corresponding changes to the documentation | ||
| - [ ] I have performed a self-review of my own code | ||
| - [ ] I have commented my code, particularly in hard-to-understand areas | ||
| - [ ] My changes generate no new warnings |
There was a problem hiding this comment.
Nice, but do you expect people to follow it :) ?
There was a problem hiding this comment.
Not sure whether people will follow it, but its good to have as a reminder to those putting in PRs.
mcbarton
force-pushed
the
Add-pull-request-template
branch
from
c336a0a
to
56094f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 73.71% 73.71%
=======================================
Files 8 8
Lines 3021 3021
=======================================
Hits 2227 2227
Misses 794 794 |
|
@vgvassilev Is this PR ok to merge? |
| - [ ] I have run `git-clang-format HEAD~` on my changes | ||
| - [ ] I have made corresponding changes to the documentation | ||
| - [ ] I have performed a self-review of my own code | ||
| - [ ] I have commented my code, particularly in hard-to-understand areas |
There was a problem hiding this comment.
Can we collapse these bullets into on that says something similar to “I have read the contribution guide recently” and move these there?
There was a problem hiding this comment.
and maybe provide a guide to open the PR using labels in the name like:
[ci/Interpreter/docs/tests...] title
Fixes # (issue)
- Tested locally
Test configuration:
should be enough in the PR to make it easy to review
There was a problem hiding this comment.
Can we collapse these bullets into on that says something similar to “I have read the contribution guide recently” and move these there?
@vgvassilev @maximusron Do we have a contributors guide somewhere already, and I just can't find it, or do I need to make one?
There was a problem hiding this comment.
I think we need to make one. Look at the one in Clad.
This PR adds a basic pull request template to the repo. @vgvassilev @maximusron This PR is ready for review.