Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN: Log ABS/ESP Activation to espActive #32743

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Jun 13, 2024

Resolves

Description

On Hyundai CAN platforms, when stock SCC is engaged, ABS/ESP activation would disengage stock SCC approximately 0.4 second after ABS/ESP was active (rising edge).

This PR introduces the following:

  • CarState.espActive: New CarState field to log active ESP events
  • CarEvent.EventName.espActive: New CarEvent.EventName field to display an alert with alert types immediateDisable and noEntry when the event is triggered
  • Log TCS11|ABS_ACT under the new CarState.espActive field

Route ID

  • 9a31d18cd1a79c69/00000004--ceb1d98f38/61

Event 1

3718.191 3718.561
image image

Event 2

3753.691 3754.051
image image

Thanks to the community 2023 Hyundai Sonata owner @BBBmau.

@github-actions github-actions bot added car vehicle-specific hyundai labels Jun 13, 2024
Copy link
Contributor

github-actions bot commented Jun 13, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sunnyhaibin sunnyhaibin changed the title Hyundai CAN: Log active ABS to accFaulted Hyundai CAN: Log ABS/ESP Activation to espActive Jun 13, 2024
@sshane
Copy link
Contributor

sshane commented Jun 25, 2024

Don't see too many segments with espActive, and is always very brief, so likely good to go!

ecdc140c384bc3fb|00000191--5e5b53a6f5--15 HYUNDAI_PALISADE 37.0
38a36c2893f16967|00000012--29530ae2dd--51 HYUNDAI_SONATA 36.0
bff778f8a1a0216d|0000032a--feef3b5a31--1 HYUNDAI_PALISADE 38.0
fea39f11afb2d0d0|000000ee--4e01528dc3--17 HYUNDAI_SONATA 18.0
1ad7728ce54a161d|00000177--24db4cd32e--5 HYUNDAI_SANTA_FE_2022 36.0
6d4f179244e5700c|0000002d--7126f3ab26--9 KIA_OPTIMA_G4_FL 36.0
310cf131d28b30d8|00000115--64d5b49f01--1 HYUNDAI_SONATA 38.0
0b91b433b9332780|0000015f--880ce4af97--5 KIA_K5_2021 24.0
310cf131d28b30d8|000001a1--eaefd0ac14--10 HYUNDAI_SONATA 36.0
49734429dda9bbe7|0000016b--43104b22fb--160 HYUNDAI_SONATA_HYBRID 88.0
1ad7728ce54a161d|0000014a--711ee77299--12 HYUNDAI_SANTA_FE_2022 29.0
1ad7728ce54a161d|00000158--417b1998d4--2 HYUNDAI_SANTA_FE_2022 37.0
f152e524f24c58d4|000000a2--d66e88c8ca--2 HYUNDAI_SONATA_HYBRID 143.0
1ad7728ce54a161d|00000080--fe7dc8362c--7 HYUNDAI_SANTA_FE_2022 1.0
310cf131d28b30d8|000001b2--5073ed993d--9 HYUNDAI_SONATA 39.0
310cf131d28b30d8|000001f9--7a3913f74a--27 HYUNDAI_SONATA 37.0
a1b9acdbb4c2fa86|00000063--6021ace719--20 KIA_NIRO_EV 139.0
ed882557605319f9|000000be--602d73e759--12 HYUNDAI_SONATA 38.0
75d3263b7dd5268b|00000066--7b51577278--8 HYUNDAI_SONATA 37.0
edbaee4bf8d33eee|000000f8--49113f2144--14 GENESIS_G70 111.0
fea39f11afb2d0d0|000000fe--790d65408e--11 HYUNDAI_SONATA 39.0
bff778f8a1a0216d|00000172--bd043fb5ef--9 HYUNDAI_PALISADE 37.0
fea39f11afb2d0d0|00000109--9d0120f6e7--22 HYUNDAI_SONATA 36.0
4019fff6e54cf1c7|000000e3--907ba85e8d--7 KIA_OPTIMA_G4_FL 37.0
310cf131d28b30d8|000001b7--b675e069c8--21 HYUNDAI_SONATA 36.0
310cf131d28b30d8|0000004f--493af5da90--1 HYUNDAI_SONATA 39.0
96c33a10ba1a97be|00000004--cd446b2de2--26 HYUNDAI_SONATA 37.0
38a36c2893f16967|00000002--4e4eafa578--86 HYUNDAI_SONATA 2.0
45a8ffd448481ce2|0000009a--e69167d226--9 HYUNDAI_SANTA_FE 38.0
310cf131d28b30d8|000000da--a222c36e86--22 HYUNDAI_SONATA 38.0
e425a1ba2f5f42b3|00000060--7f2414b75f--2 HYUNDAI_SONATA 36.0
fea39f11afb2d0d0|000000ef--f33fb9a698--11 HYUNDAI_SONATA 38.0
ed882557605319f9|00000027--013f4075d8--4 HYUNDAI_SONATA 38.0
e93eea88c88c9d46|00000228--f31682bc19--4 HYUNDAI_KONA_EV_2022 37.0
310cf131d28b30d8|00000208--c0952e612e--18 HYUNDAI_SONATA 93.0
e3500498d01af116|2024-05-06--18-46-26--6 HYUNDAI_SONATA_LF 36.0
4df896aa825bd9b3|00000082--d2efc7d2db--3 HYUNDAI_SONATA 41.0
Checked routes: 9849, dongles: 52 platforms: {<CAR.HYUNDAI_PALISADE>: 651, 'KIA_NIRO_EV': 663, 'HYUNDAI_SONATA': 2683, 'GENESIS_G70': 615, 'HYUNDAI_KONA_EV_2022': 751, 'KIA_K5_2021': 505, 'HYUNDAI_SONATA_HYBRID': 837, 'HYUNDAI_SANTA_FE_2022': 1042, 'HYUNDAI_IONIQ_PHEV': 105, 'KIA_OPTIMA_G4_FL': 144, 'GENESIS_G90': 423, 'HYUNDAI_IONIQ_EV_2020': 334, 'HYUNDAI_ELANTRA_2021': 395, <CAR.HYUNDAI_SONATA_LF>: 193, <CAR.HYUNDAI_SANTA_FE>: 361, 'HYUNDAI_ELANTRA_HEV_2021': 140, 'KIA_K5_HEV_2020': 5, 'KIA_NIRO_PHEV_2022': 1, 'KIA_STINGER_2022': 1}

@sshane sshane merged commit 36eafc0 into commaai:master Jun 25, 2024
15 checks passed
@sunnyhaibin sunnyhaibin deleted the hkg-can-acc-fault branch June 25, 2024 03:15
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
* Hyundai CAN: Log active ABS to accFaulted

* Add comments

* `espActive` to CarState and CarEvent.EventName

* re-order

---------

Co-authored-by: Shane Smiskol <[email protected]>
old-commit-hash: 36eafc0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants