-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyundai CAN: Log ABS/ESP Activation to espActive
#32743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
sunnyhaibin
changed the title
Hyundai CAN: Log active ABS to
Hyundai CAN: Log ABS/ESP Activation to Jun 13, 2024
accFaulted
espActive
sunnyhaibin
force-pushed
the
hkg-can-acc-fault
branch
from
June 13, 2024 23:36
a671cd6
to
18f4c7b
Compare
sunnyhaibin
force-pushed
the
hkg-can-acc-fault
branch
from
June 13, 2024 23:37
18f4c7b
to
45d97e6
Compare
Don't see too many segments with espActive, and is always very brief, so likely good to go!
|
This was referenced Jul 1, 2024
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* Hyundai CAN: Log active ABS to accFaulted * Add comments * `espActive` to CarState and CarEvent.EventName * re-order --------- Co-authored-by: Shane Smiskol <[email protected]> old-commit-hash: 36eafc0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Description
On Hyundai CAN platforms, when stock SCC is engaged, ABS/ESP activation would disengage stock SCC approximately 0.4 second after ABS/ESP was active (rising edge).
This PR introduces the following:
CarState.espActive
: NewCarState
field to log active ESP eventsCarEvent.EventName.espActive
: NewCarEvent.EventName
field to display an alert with alert typesimmediateDisable
andnoEntry
when the event is triggeredTCS11|ABS_ACT
under the newCarState.espActive
fieldRoute ID
9a31d18cd1a79c69/00000004--ceb1d98f38/61
Event 1
Event 2
Thanks to the community 2023 Hyundai Sonata owner @BBBmau.