Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic: Electronic Stability Control Active during normal openpilot use #32888

Closed
BBBmau opened this issue Jul 1, 2024 · 1 comment
Closed
Labels

Comments

@BBBmau
Copy link
Contributor

BBBmau commented Jul 1, 2024

Describe the bug

Normal use of openpilot, required me to take control but worked fine after. unsure of what could've caused this. Comes from pulling new commits from master.

Exact occurrence is here: https://connect.comma.ai/9a31d18cd1a79c69/00000001--79aa41f7e0/3484/3526

replicate-prediction-jmj86jwj0srgc0cge03rp60bp0.mov

Provide a route where the issue occurs

9a31d18cd1a79c69/00000001--79aa41f7e0

openpilot version

66e1810

Additional info

I was testing out @ugtthis new Display Alert Cluster when this panic occurred but judging on the diff between the fork and commit from master, the code only updates UI. commaai:openpilot:66e1810c0de88f4b927b7a46d12ba96304052ace...ugtthis:openpilot:dac-ui

@BBBmau BBBmau added the bug label Jul 1, 2024
@jyoung8607
Copy link
Collaborator

The alert was added recently in #32743, as the resolution for your earlier issue #32737.

HKG ACC disengages on stability control activity, which disengages openpilot as well. Before that PR, you would have had a nearly silent disengagement, no warning to the driver beyond the usual sound. That's a bad thing, hence the warning. It may need to be added for other vehicles as well.

Closing since this is working as-designed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants