Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setproctitle dependency #32666

Closed
wants to merge 2 commits into from
Closed

Conversation

markypizz
Copy link

@markypizz markypizz commented Jun 8, 2024

[Edited]

Description

Replace setproctitle dependency with our own small helper

Verification

Passing CI, observed proc title change when running modeld, (see #32666 (comment))

Copy link
Contributor

github-actions bot commented Jun 8, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

Copy link
Contributor

@adeebshihadeh adeebshihadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome, and yeah this is the right general direction.

Tests are failing because there's still a setproctitle import. CI green check mark + verify the title shows up in htop is enough validation for this change

common/setproctitle.py Show resolved Hide resolved
common/setproctitle.py Outdated Show resolved Hide resolved
@schlimeszn schlimeszn mentioned this pull request Jun 8, 2024
@markypizz
Copy link
Author

markypizz commented Jun 9, 2024

Addresses #32660 . Let me know of anything else to change. Thanks!

openpilot-py3.11vscode ➜ /workspaces/ubuntu $ ps -a
    PID TTY          TIME CMD
  37224 pts/0    00:00:01 poetry
  49515 pts/1    00:00:15 loggerd
  49533 pts/1    00:00:15 loggerd
  95648 pts/1    00:00:00 python3
 103095 pts/1    00:00:00 selfdrive.model
 103204 pts/7    00:00:00 ps

@markypizz markypizz marked this pull request as ready for review June 9, 2024 00:32
@adeebshihadeh
Copy link
Contributor

Doesn't seem to work with htop still.

@adeebshihadeh
Copy link
Contributor

Ended up merging #32667 since it made the agnos-builder PR and had a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants