-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace setproctitle dependency #32666
Conversation
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome, and yeah this is the right general direction.
Tests are failing because there's still a setproctitle
import. CI green check mark + verify the title shows up in htop
is enough validation for this change
Addresses #32660 . Let me know of anything else to change. Thanks!
|
Doesn't seem to work with |
Ended up merging #32667 since it made the agnos-builder PR and had a test. |
[Edited]
Description
Replace
setproctitle
dependency with our own small helperVerification
Passing CI, observed proc title change when running
modeld
, (see #32666 (comment))