-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$100 bounty] Remove setproctitle
dependency
#32660
Comments
Curious if I'm trending in the right direction. Thanks! |
Truly replacing Linux setproctitle() requires clobbering the original argv[], which is some real sausage-making. However, @cl0cks4fe has taken a shot in #32691. The other approaches are setting a thread title. htop doesn't show them because it's configured not to. IMO we should fix the htop config, because then we'll actually start seeing see the thread names we're already setting in camerad, loggerd, and boardd. Then we can migrate setproctitle() users to setting thread titles, and dispose of the dependency that way. |
Agreed with the above. htop is looking at /proc/{pid}/cmdline, which can't be changed other than clobbering argv and the mess associated with it. Is the setting of the title purely for cosmetics or for some other reason? |
Replace
setproctitle
with our own small helper incommon/
. Just needs to work on Linux.The text was updated successfully, but these errors were encountered: