-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HKG: Car Port for Kia Sportage Plug-in Hybrid 2023 #1138
base: master
Are you sure you want to change the base?
HKG: Car Port for Kia Sportage Plug-in Hybrid 2023 #1138
Conversation
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is one of those vehicles with different/unusual EPS response, where we need to tone down openpilot's output, mention that separately in the PR as a blocker. We don't want to accidentally merge this before figuring out a solution.
According to the history this vehicle does have much higher lateral control authority, and it also has the known issues with "grasp wheel" and "take a break" HUD alerts. Those need to be sorted out before the car can ship as fully supported, and since it's a combined platform with the existing Sportage, there's not an easy option to merge as dashcam either. I think all these issues are fixable, but they're blockers for this PR.
|
3787b6d
to
84485cc
Compare
Using |
…ge-phev-2023-port
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a route that @sunnyhaibin requested in a discord thread, which evaluates sunnyhaibin/openpilot-1@e10a809 on a 2023 Kia Sportage PHEV.
The route id is 428412ad82894ba3/00000040--6ea91f379f/1
(also on comma connect). This route includes some interstate driving where the driver grasp not detected appeared.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyoung8607 is this PR reviewable now after @sunnyhaibin's commits to address the lateral control authority and alerts along with the test route above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In part. I'll try to write up some comments later today.
Checklist
selfdrive/car/docs.py
to generate new docs428412ad82894ba3|2023-10-27--15-44-21
428412ad82894ba3|2023-12-09--17-01-47
Link to all physical parts during installation
Thanks to the community 2022 Kia Sportage Plug-in Hybrid owner dhimmels.
Requires
Supersedes commaai/openpilot#30575