Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: Car Port for Kia Sportage Plug-in Hybrid 2023 #1138

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Aug 20, 2024

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with stock system: 428412ad82894ba3|2023-10-27--15-44-21
  • route with openpilot: 428412ad82894ba3|2023-12-09--17-01-47
  • harness Type: Hyundai N
  • architecture: CAN-FD

Link to all physical parts during installation

Thanks to the community 2022 Kia Sportage Plug-in Hybrid owner dhimmels.

Requires

Supersedes commaai/openpilot#30575

@github-actions github-actions bot added car related to opendbc/car/ hyundai fingerprint labels Aug 20, 2024
Copy link
Contributor

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

Copy link
Collaborator

@jyoung8607 jyoung8607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is one of those vehicles with different/unusual EPS response, where we need to tone down openpilot's output, mention that separately in the PR as a blocker. We don't want to accidentally merge this before figuring out a solution.

opendbc/car/hyundai/values.py Outdated Show resolved Hide resolved
@jyoung8607 jyoung8607 marked this pull request as draft September 6, 2024 15:52
@jyoung8607
Copy link
Collaborator

According to the history this vehicle does have much higher lateral control authority, and it also has the known issues with "grasp wheel" and "take a break" HUD alerts.

Those need to be sorted out before the car can ship as fully supported, and since it's a combined platform with the existing Sportage, there's not an easy option to merge as dashcam either. I think all these issues are fixable, but they're blockers for this PR.

  • Need to handle drastic change in lateral control response
  • Need to handle spurious HUD alerts

@sunnyhaibin
Copy link
Contributor Author

Using fwdCamera for now to distinguish between PHEV and other variants for the second alternative limits.

Copy link

@dhimmel dhimmel Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a route that @sunnyhaibin requested in a discord thread, which evaluates sunnyhaibin/openpilot-1@e10a809 on a 2023 Kia Sportage PHEV.

The route id is 428412ad82894ba3/00000040--6ea91f379f/1 (also on comma connect). This route includes some interstate driving where the driver grasp not detected appeared.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jyoung8607 is this PR reviewable now after @sunnyhaibin's commits to address the lateral control authority and alerts along with the test route above?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In part. I'll try to write up some comments later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ fingerprint hyundai
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants