Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out openpilot and agnos python dependencies #265

Merged
merged 29 commits into from
Sep 4, 2024
Merged

Split out openpilot and agnos python dependencies #265

merged 29 commits into from
Sep 4, 2024

Conversation

andiradulescu
Copy link
Collaborator

@andiradulescu andiradulescu commented Jul 26, 2024 •
edited
Loading

Resolves #23

@andiradulescu andiradulescu mentioned this pull request Jul 26, 2024
Closed
@andiradulescu
Copy link
Collaborator Author

this branch is driving my car right now 😍

@andiradulescu andiradulescu marked this pull request as ready for review July 26, 2024 13:11
@andiradulescu
Copy link
Collaborator Author

andiradulescu commented Jul 26, 2024 •
edited
Loading

For #225

du -sh system.img
3.4G	system.img

@adeebshihadeh
Copy link
Contributor

For #225

du -sh system.img
3.4G	system.img

Would be cool to make a script that does some basic analysis and run it in CI.

@andiradulescu
Copy link
Collaborator Author

I'll add a step in the CI at the end.

adeebshihadeh
adeebshihadeh requested changes Jul 28, 2024
View reviewed changes
Dockerfile.agnos Outdated Show resolved Hide resolved
@adeebshihadeh adeebshihadeh marked this pull request as draft August 4, 2024 22:11
@andiradulescu andiradulescu changed the title make openpilot a dependency of agnos Split out openpilot and agnos python dependencies Sep 3, 2024
@andiradulescu andiradulescu mentioned this pull request Sep 4, 2024
Merged
@andiradulescu
Copy link
Collaborator Author

andiradulescu commented Sep 4, 2024 •
edited
Loading

master:

  4.3G	/
  1.1G	/usr/local/venv
  854M	/usr/lib/aarch64-linux-gnu
  338M	/usr/lib/llvm-18
  260M	/usr/lib/gcc
  155M	/usr/lib/arm-linux-gnueabihf
  331M	/usr/bin
  328M	/usr/share
  166M	/usr/comma

openpilot + openpilot[testing]:

3.8G	/
581M	/usr/local/venv
854M	/usr/lib/aarch64-linux-gnu
338M	/usr/lib/llvm-18
260M	/usr/lib/gcc
155M	/usr/lib/arm-linux-gnueabihf
331M	/usr/bin
328M	/usr/share
166M	/usr/comma

@andiradulescu andiradulescu marked this pull request as ready for review September 4, 2024 14:35
adeebshihadeh
adeebshihadeh reviewed Sep 4, 2024
View reviewed changes
sync_openpilot_dependencies.sh Outdated Show resolved Hide resolved
userspace/uv/pyproject.toml Show resolved Hide resolved
userspace/uv/pyproject.toml Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

✅ AGNOS update 7d85c97 ready

In an openpilot branch, download agnos.json in system/hardware/tici/ and update AGNOS_VERSION to "7d85c97dd6ddee81c407aec9e1f3ab9c7459d858" in launch_env.sh.

For flashing locally, download and unarchive the images in agnos-builder/output and flash with ./flash_all.sh.

Images:

Stats:

3.3G	/
854M	/usr/lib/aarch64-linux-gnu
338M	/usr/lib/llvm-18
260M	/usr/lib/gcc
155M	/usr/lib/arm-linux-gnueabihf
331M	/usr/bin
328M	/usr/share
166M	/usr/comma

@adeebshihadeh adeebshihadeh merged commit 30500ee into commaai:master Sep 4, 2024
2 checks passed
@andiradulescu andiradulescu deleted the agnos-pydep-on-openpilot branch September 4, 2024 22:36
@andiradulescu
Copy link
Collaborator Author

andiradulescu commented Sep 5, 2024 •
edited
Loading

@adeebshihadeh uv somehow decided to not use the system env anymore to install, thus no python packages installed in this last image - fixing this in #341 + uv sync might not be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split out openpilot and system python dependencies
2 participants
@andiradulescu @adeebshihadeh