Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KUBESAW-187: Have a unique label for our operators #597

Merged
merged 2 commits into from
Sep 19, 2024
Merged

KUBESAW-187: Have a unique label for our operators #597

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a7e51
KUBESAW-170: Have a unique label for our operators
fbm3307 Sep 19, 2024
f1376e6
add unique names instead of replacing it
fbm3307 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v1
kind: Namespace
metadata:
labels:
control-plane: controller-manager
control-plane: kubesaw-controller-manager
name: system
---
apiVersion: apps/v1
Expand All @@ -11,18 +11,18 @@ metadata:
name: controller-manager
namespace: system
labels:
control-plane: controller-manager
control-plane: kubesaw-controller-manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I'm not sure if this labels is not used somewhere else (eg in sanbox-sre). Let's keep the label there and add a new one instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you are right, added new ones now.

annotations:
kubectl.kubernetes.io/default-container: manager
spec:
selector:
matchLabels:
control-plane: controller-manager
control-plane: kubesaw-controller-manager
replicas: 1
template:
metadata:
labels:
control-plane: controller-manager
control-plane: kubesaw-controller-manager
spec:
securityContext:
runAsNonRoot: true
Expand Down
Loading